-
Notifications
You must be signed in to change notification settings - Fork 61
Feat: adds clear function to HitsSource #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 7 commits
f5cdd67
d7234b5
1f2ecf3
3c359d4
5db5853
5a499ff
8709e16
c3a7367
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,42 +68,83 @@ | |
| } | ||
| } | ||
|
|
||
| #if os(iOS) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By removing this conditional compiling clause, you make it fail while compiling for
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, my bad. Fixed |
||
| @available(iOS 13.0, tvOS 13.0, watchOS 7.0, *) | ||
| struct HitsView_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| let hitsController: HitsObservableController<String> = .init() | ||
| NavigationView { | ||
| HitsList(hitsController) { string, _ in | ||
| VStack { | ||
| HStack { | ||
| Text(string ?? "---") | ||
| .frame(maxWidth: .infinity, minHeight: 30, maxHeight: .infinity, alignment: .leading) | ||
| .padding(.horizontal, 16) | ||
| } | ||
| Divider() | ||
| @available(iOS 13.0, tvOS 13.0, watchOS 7.0, *) | ||
| struct HitsView_Previews: PreviewProvider { | ||
|
|
||
| struct PreviewRecord<Value: Codable>: Codable { | ||
| let objectID: ObjectID | ||
| let value: Value | ||
|
|
||
| init(_ value: Value, objectID: ObjectID = ObjectID(rawValue: UUID().uuidString)) { | ||
| self.value = value | ||
| self.objectID = objectID | ||
| } | ||
|
|
||
| static func withValue(_ value: Value) -> Self { | ||
| .init(value) | ||
| } | ||
| } | ||
|
|
||
| static let rawHits: Data = """ | ||
|
||
| { | ||
| "hits": [ | ||
| { | ||
| "objectID": "1", | ||
| "value": "h1" | ||
| }, | ||
| { | ||
| "objectID": "2", | ||
| "value": "h2" | ||
| } | ||
| ] | ||
| } | ||
| """.data(using: .utf8)! | ||
|
|
||
| static let hitsController: HitsObservableController<PreviewRecord<String>> = .init() | ||
|
|
||
| static let interactor = HitsInteractor<PreviewRecord<String>>(infiniteScrolling: .off, showItemsOnEmptyQuery: true) | ||
|
|
||
| static var previews: some View { | ||
| NavigationView { | ||
| HitsList(hitsController) { string, _ in | ||
| VStack { | ||
| HStack { | ||
| Text(string?.value ?? "---") | ||
| .frame(maxWidth: .infinity, minHeight: 30, maxHeight: .infinity, alignment: .leading) | ||
| .padding(.horizontal, 16) | ||
| } | ||
| } noResults: { | ||
| Text("No results") | ||
| Divider() | ||
| } | ||
| .padding(.top, 20) | ||
| .onAppear { | ||
| hitsController.hits = ["One", "Two", "Three"] | ||
| }.navigationBarTitle("Hits") | ||
| } noResults: { | ||
| Text("No results") | ||
| } | ||
| NavigationView { | ||
| HitsList(hitsController) { string, _ in | ||
| VStack { | ||
| HStack { | ||
| Text(string ?? "---") | ||
| } | ||
| Divider() | ||
| .padding(.top, 20) | ||
| .onAppear { | ||
| hitsController.hitsSource = interactor | ||
|
|
||
| let results = try! JSONDecoder().decode(SearchResponse.self, from: rawHits) | ||
|
|
||
| interactor.onResultsUpdated.subscribe(with: hitsController) { (reb, hit) in | ||
| reb.reload() | ||
| } | ||
| interactor.update(results) | ||
| } | ||
| .navigationBarTitle("Hits") | ||
| } | ||
|
|
||
| NavigationView { | ||
| HitsList(hitsController) { string, _ in | ||
| VStack { | ||
| HStack { | ||
| Text(string?.value ?? "---") | ||
| } | ||
| } noResults: { | ||
| Text("No results") | ||
| }.navigationBarTitle("Hits") | ||
| Divider() | ||
| } | ||
| } noResults: { | ||
| Text("No results") | ||
| } | ||
| .navigationBarTitle("Hits") | ||
| } | ||
| } | ||
| #endif | ||
| } | ||
| #endif | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is set from the
InstantSearchCoremodule, so it cannot be declared asprivate(set)without compilation failure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have any compilation failure targeting macOS and iOS. Am I missing something?