fix: add requestOptions to MultiSearcher init#341
Merged
Conversation
Haroenv
reviewed
Jun 27, 2025
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
thank you! couple comments missing
aallam
reviewed
Jun 27, 2025
Haroenv
reviewed
Jun 30, 2025
Haroenv
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultiSearcherextra headers viarequestOptionsdo not work as they do not get forwarded in the multi query request.This PR adds a
requestOptionsarg to theMultiSearcherinit.FX-3397
Result
Extra headers (and any option request options) now get forwarded to the multi query request.