Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions CI workflows to use newer macOS runner versions and corresponding Xcode versions. It also removes the deprecated carthage-prebuild script that was previously required for Carthage dependency management, and includes a minor refactoring of generic type parameter naming in the core hits extraction functionality.
- Updates macOS runners from version 13 to 14/15 with corresponding Xcode version upgrades (14.2 → 15.2/16.0)
- Removes the
carthage-prebuildscript and all references to it - Refactors generic type parameter names from
TtoHitfor improved code clarity
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/swift.yml |
Updates macOS runner to 15 and Xcode to 16.0 for Swift tests |
.github/workflows/pods.yml |
Updates macOS runner to 14 and Xcode to 15.2 for CocoaPods linting jobs |
.github/workflows/carthage.yml |
Updates macOS runner to 15, Xcode to 16.0, removes prebuild step, adds GitHub token |
carthage-prebuild |
Removes deprecated script that generated Xcode projects for Carthage dependencies |
Readme.md |
Removes reference to the now-deleted carthage-prebuild script from installation instructions |
Sources/InstantSearchCore/Hits/HitsExtractable.swift |
Renames generic type parameter from T to Hit for better semantic clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
afrencalg
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update macOS version to have a working CI again
Result
Ci passes
Carthage pass seems flaky, may need to remove that one