Skip to content

fix(autocomplete): item ids are shifted when there are deduped items#6862

Merged
aymeric-giraudet merged 4 commits intomasterfrom
fix/ids-shift-when-deduped
Jan 15, 2026
Merged

fix(autocomplete): item ids are shifted when there are deduped items#6862
aymeric-giraudet merged 4 commits intomasterfrom
fix/ids-shift-when-deduped

Conversation

@aymeric-giraudet
Copy link
Member

@aymeric-giraudet aymeric-giraudet commented Jan 13, 2026

Summary

FX-3661

@aymeric-giraudet aymeric-giraudet requested review from a team, Haroenv and shaejaz and removed request for a team January 13, 2026 12:49
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 13, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c59b7f:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for this please @copilot

Copy link

Copilot AI commented Jan 14, 2026

@Haroenv I've opened a new pull request, #6865, to work on those changes. Once the pull request is ready, I'll request review from you.

@aymeric-giraudet aymeric-giraudet requested review from a team and FabienMotte and removed request for a team January 14, 2026 10:02
Copy link
Contributor

@FabienMotte FabienMotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (missing bundlesize update and test)

@aymeric-giraudet
Copy link
Member Author

aymeric-giraudet commented Jan 14, 2026

Added proper tests @Haroenv, tests that hi is applied, previously it would have applied hello

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just update bundlesize :) Netlify check looks unrelated so likely will pass on next push

@aymeric-giraudet aymeric-giraudet merged commit 2b24d3b into master Jan 15, 2026
14 checks passed
@aymeric-giraudet aymeric-giraudet deleted the fix/ids-shift-when-deduped branch January 15, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants