Conversation
1 task
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4368e8a:
|
Haroenv
requested review from
a team,
aymeric-giraudet and
shaejaz
and removed request for
a team
Member
aymeric-giraudet
left a comment
aymeric-giraudet
left a comment
There was a problem hiding this comment.
iirc useId was for server side rendering to avoid hydration issues. (it generates the ID on server and hydrates on client)
Since Autocomplete does not need SSR, we could also generate IDs with something else like crypto ?
Contributor
Author
|
Won't the input still be rendered in server side rendering @aymeric-giraudet? |
aymeric-giraudet
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For now just a wip, as it needs to be tested out.
useId was introduced in react 18, but we have react 16 support. Therefore we should shim React.useId
Result
fixes #6871