feat(filterSuggestions): add minimum loading duration to prevent skeleton flash#6878
Merged
FabienMotte merged 3 commits intomasterfrom Jan 27, 2026
Merged
Conversation
Haroenv
approved these changes
Jan 27, 2026
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
looks good. Should we add a test for this?
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 91a965e:
|
shaejaz
approved these changes
Jan 27, 2026
Contributor
Author
I fixed the existing tests and added a new one |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a minimum 300ms loading duration for the filter suggestions skeleton to prevent a flash when results are returned quickly from the Agent Studio API cache.
Result
When cached results return in <300ms, the skeleton now displays for the full 300ms before showing results, providing a smoother visual transition.