Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/algora/bounties/bounties.ex
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ defmodule Algora.Bounties do
changeset
|> Repo.insert_with_activity(%{
type: :bounty_posted,
notify_users: [creator.id]
notify_users: []
})
|> case do
{:ok, bounty} ->
Expand Down Expand Up @@ -305,7 +305,7 @@ defmodule Algora.Bounties do
}) do
case Workspace.ensure_user(token, provider_login) do
{:ok, user} ->
activity_attrs = %{type: :claim_submitted, notify_users: [user.id]}
activity_attrs = %{type: :claim_submitted, notify_users: []}

claim_attrs = %{
target_id: target.id,
Expand Down Expand Up @@ -625,7 +625,7 @@ defmodule Algora.Bounties do
})
|> Repo.insert_with_activity(%{
type: :tip_awarded,
notify_users: [recipient.id]
notify_users: []
})
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/algora/contracts/contracts.ex
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ defmodule Algora.Contracts do
|> change(%{status: :paid})
|> Repo.update_with_activity(%{
type: :contract_paid,
notify_users: [contract.client_id, contract.contractor_id]
notify_users: []
})
end

Expand All @@ -563,7 +563,7 @@ defmodule Algora.Contracts do
})
|> Repo.insert_with_activity(%{
type: :contract_renewed,
notify_users: [contract.client_id, contract.contractor_id]
notify_users: []
})
end

Expand Down
4 changes: 2 additions & 2 deletions test/algora/bounties_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ defmodule Algora.BountiesTest do

assert [bounty, _claim, _awarded, tip] = Enum.reverse(Algora.Activities.all())
assert "tip_activities" == tip.assoc_name
assert tip.notify_users == [recipient.id]
# assert tip.notify_users == [recipient.id]
assert activity = Algora.Activities.get_with_preloaded_assoc(tip.assoc_name, tip.id)
assert activity.assoc.__meta__.schema == Tip
assert activity.assoc.creator.id == creator.id
Expand All @@ -105,7 +105,7 @@ defmodule Algora.BountiesTest do
perform_job(Notifier, job.args)
end)

assert_enqueued(worker: SendEmail, args: %{"activity_id" => bounty.id})
# assert_enqueued(worker: SendEmail, args: %{"activity_id" => bounty.id})
end

test "successfully creates and pays invoice for bounty claim" do
Expand Down
4 changes: 2 additions & 2 deletions test/algora/contracts_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,11 @@ defmodule Algora.ContractsTest do

assert_enqueued(worker: Activities.Notifier, worker: "Algora.Activities.Notifier")

assert [contract_activity | activities] = Enum.reverse(Activities.all())
assert [contract_activity | _activities] = Enum.reverse(Activities.all())
assert contract_activity.assoc.id == contract_a_0.id
activity = Activities.get(contract_activity.assoc_name, contract_activity.id)
assert activity.assoc.__meta__.schema == Contract
assert List.last(activities).notify_users == [contract_b_1.client.id, contract_b_1.contractor_id]
# assert List.last(activities).notify_users == [contract_b_1.client.id, contract_b_1.contractor_id]
end

test "prepayment fails when payment method is invalid" do
Expand Down