Skip to content

fix: ensure nested dataclasses in state accessors are loaded properly#36

Merged
aorumbayev merged 2 commits intomainfrom
fix/feedback-batch-2
Feb 3, 2025
Merged

fix: ensure nested dataclasses in state accessors are loaded properly#36
aorumbayev merged 2 commits intomainfrom
fix/feedback-batch-2

Conversation

@aorumbayev
Copy link
Copy Markdown
Contributor

@aorumbayev aorumbayev commented Jan 31, 2025

Proposed Changes

  • Minor bug fix where structs returned from state accessors wouldn't load the nested dataclasses properly (reported by @cusma)
  • Renaming global struct example to structs and adding extra test for box local state and global state accessors with nested dataclasses (both from method calls and from state)
  • Reusing, now moved, CommonAppCallParams and CommonAppCreateCallParams from algokit-utils-py

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_client_generator
   __main__.py220%1–3
   cli.py48480%1–87
   document.py82791%44, 47, 49–50, 55, 74–75
   generator.py31197%23
   spec.py2071692%86, 116–119, 219–223, 253, 269, 350–351, 395, 410
   utils.py2194878%11, 20, 24, 28, 32, 36, 40, 44, 55, 58, 63–64, 75–76, 82–84, 89–91, 94–96, 99, 102, 105, 108–110, 159–160, 194, 198, 201–202, 218, 220, 231–232, 249, 261–264, 268, 278, 281, 283
src/algokit_client_generator/generators
   composer.py51198%29
   typed_client.py326898%59, 188, 287, 586, 676, 686, 725, 836
   typed_factory.py219399%64, 94, 226
TOTAL125613489% 

Tests Skipped Failures Errors Time
42 0 💤 0 ❌ 0 🔥 19.583s ⏱️

@aorumbayev aorumbayev force-pushed the fix/feedback-batch-2 branch from bfe0b6c to 5bf1780 Compare February 1, 2025 01:10
@aorumbayev aorumbayev force-pushed the fix/feedback-batch-2 branch from 362530c to 720a389 Compare February 3, 2025 10:21
@aorumbayev aorumbayev merged commit 58f13aa into main Feb 3, 2025
6 checks passed
@aorumbayev aorumbayev deleted the fix/feedback-batch-2 branch February 3, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants