Skip to content

fix: minor patches in dataclass inheritance; fixes for mypy errors; addressing internal feedback #37

Merged
aorumbayev merged 2 commits intomainfrom
feedback/improvements
Feb 5, 2025
Merged

fix: minor patches in dataclass inheritance; fixes for mypy errors; addressing internal feedback #37
aorumbayev merged 2 commits intomainfrom
feedback/improvements

Conversation

@aorumbayev
Copy link
Copy Markdown
Contributor

@aorumbayev aorumbayev commented Feb 5, 2025

Proposed Changes

  • Minor fixes to resolve mypy errors when used with lint command in python template
  • Based on feedback from @cusma , removes the requirement to explicitly pass method argument in dataclass for create,update,delete params in factory deploy method:
    • Removes union types from args field, requiring explicit dataclasses when dealing with deploy method in order to figure out the signature (which now gets generated in abi_method_signature property on all args dataclasses) -> aligns further with the approach used in v1 of generators.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_client_generator
   __main__.py220%1–3
   cli.py48480%1–87
   document.py82791%44, 47, 49–50, 55, 74–75
   generator.py31197%23
   spec.py2071692%86, 116–119, 219–223, 253, 269, 350–351, 395, 410
   utils.py2194878%11, 20, 24, 28, 32, 36, 40, 44, 55, 58, 63–64, 75–76, 82–84, 89–91, 94–96, 99, 102, 105, 108–110, 159–160, 194, 198, 201–202, 218, 220, 231–232, 249, 261–264, 268, 278, 281, 283
src/algokit_client_generator/generators
   composer.py51198%29
   typed_client.py328898%59, 188, 287, 590, 680, 690, 729, 840
   typed_factory.py213399%64, 94, 227
TOTAL125213489% 

Tests Skipped Failures Errors Time
42 0 💤 0 ❌ 0 🔥 19.716s ⏱️

@aorumbayev aorumbayev changed the title fix: minor patches in dataclass inheritance; fixes for mypy errors fix: minor patches in dataclass inheritance; fixes for mypy errors; addressing internal feedback Feb 5, 2025
… require args dataclass (to figure out signature)
@aorumbayev aorumbayev force-pushed the feedback/improvements branch from 843dcb7 to 8e2344c Compare February 5, 2025 20:31
@aorumbayev aorumbayev merged commit 82a1a1c into main Feb 5, 2025
6 checks passed
@aorumbayev aorumbayev deleted the feedback/improvements branch February 5, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants