fix: minor patches in dataclass inheritance; fixes for mypy errors; addressing internal feedback #37
Merged
aorumbayev merged 2 commits intomainfrom Feb 5, 2025
Merged
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
neilcampbell
approved these changes
Feb 5, 2025
… require args dataclass (to figure out signature)
843dcb7 to
8e2344c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
methodargument in dataclass for create,update,delete params in factory deploy method:methodexplicitly.abi_method_signatureproperty on all args dataclasses) -> aligns further with the approach used in v1 of generators.