Skip to content

fix: support assets which signal arc3 conformance using asset name #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support assets which signal arc3 conformance using asset name #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/features/assets/data/asset-metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const createAssetMetadataResult = async (

// Get ARC-3 or ARC-19 metadata if applicable
const [isArc3, isArc19] = assetResult.params.url
? ([isArc3Url(assetResult.params.url), isArc19Url(assetResult.params.url)] as const)
? ([isArc3Url(assetResult.params.url, assetResult.params.name), isArc19Url(assetResult.params.url)] as const)
: [false, false]

if (assetResult.params.url && (isArc3 || isArc19)) {
Expand Down
2 changes: 1 addition & 1 deletion src/features/assets/mappers/asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ const asStandardsUsed = (assetResult: AssetResult, metadataResult: AssetMetadata
const standardsUsed = new Set<AssetStandard>()

const [isArc3, isArc19] = assetResult.params.url
? ([isArc3Url(assetResult.params.url), isArc19Url(assetResult.params.url)] as const)
? ([isArc3Url(assetResult.params.url, assetResult.params.name), isArc19Url(assetResult.params.url)] as const)
: [false, false]
if (isArc3) {
standardsUsed.add(AssetStandard.ARC3)
Expand Down
11 changes: 8 additions & 3 deletions src/features/assets/utils/arc3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
import { AssetId } from '../data/types'

// When the URL contains #arc3 or @arc3, it follows ARC-3
export const isArc3Url = (assetUrl: string) => assetUrl.includes('#arc3') || assetUrl.includes('@arc3')
// Check if the asset details follow ARC-3
export const isArc3Url = (assetUrl: string, assetName: string | undefined) =>
assetUrl.endsWith('#arc3') || (assetName && (assetName === 'arc3' || assetName.endsWith('@arc3')))

export const getArc3Url = (assetId: AssetId, url: string): string => {
return url.replace('{id}', assetId.toString())
let result = url.replace('{id}', assetId.toString())
if (result.endsWith('#arc3')) {
result = result.slice(0, -5)
}
return result
}