Feat/mobile menu drawer #509
Open
+1,272
−1,416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ind v4 util classes
…pushed to further pr
Deploying algokit-lora with
|
| Latest commit: |
11e5a4d
|
| Status: | 🚫 Build failed. |
mrcointreau
requested changes
Oct 22, 2025
| {/* Items */} | ||
| <nav className="p-3 space-y-1"> | ||
| {menuItems.map((item, idx) => ( | ||
| <div onClick={handleClose}> |
There was a problem hiding this comment.
You’re missing a unique key for each child, React will warn about that.
Possible fixes:
key={item.urlTemplate.toString()}- or add an
idfield tomenuItemsand usekey={item.id}
| </button> | ||
| </div> | ||
|
|
||
| <Search /> |
There was a problem hiding this comment.
Might be missing className="w-full" on the <Search /> unless the design intentionally limits its width.
Suggested change
| <Search /> | |
| <Search className="w-full"/> |
| "eslint-plugin-react": "^7.37.2", | ||
| "eslint-plugin-react-hooks": "^5.0.0", | ||
| "eslint-plugin-react-refresh": "^0.4.20", | ||
| "eslint-plugin-tailwindcss": "^3.17.5", |
There was a problem hiding this comment.
👀
Noticed eslint-plugin-tailwindcss was removed here: is that because it’s still in beta for Tailwind v4?
| formAction={ | ||
| <FormActions> | ||
| {/* eslint-disable-next-line tailwindcss/no-custom-classname */} | ||
| <SubmitButton className="plausible-event-name=app-lab-use-existing-app-id">Use existing</SubmitButton> |
There was a problem hiding this comment.
I noticed that buttons appear to have lost the pointer.
| const [layout, setLayout] = useLayout() | ||
| const isOpen = !!layout.isDrawerMenuExpanded | ||
|
|
||
| const menuItems = useMemo( |
There was a problem hiding this comment.
We should be able to extract the json out into a seperate file and share with the left side menu component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Tailwind v4 Upgrade & New Mobile Drawer
Summary
Upgraded Tailwind CSS to v4 and implemented a new menu drawer for mobile and tablet to improve responsiveness and accessibility.
Changes
Result
Cleaner mobile layout, better navigation flow, and consistent styling across breakpoints.