Conversation
joe-p
approved these changes
Nov 21, 2025
Contributor
joe-p
left a comment
joe-p
left a comment
There was a problem hiding this comment.
Kinda surprised the SDK doesn't have the block logs endpoint. I would think that'd be useful for events. Then again no one really uses them. Regardless matching current SDK makes sense to me.
|
|
||
| .tmp/ No newline at end of file | ||
| .tmp/ | ||
| scripts/find-data No newline at end of file |
Contributor
There was a problem hiding this comment.
Might be useful to keep these?
Contributor
Author
There was a problem hiding this comment.
Yeah, I was thinking about keeping these, but they are still a wip and might overlap with the work that Luca might do. Might add these later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed private, experimental and these three endpoints since they are not being generated in the algod client: "Metrics", "SwaggerJSON", "GetBlockLogs"