Draft
Conversation
joe-p
commented
Sep 23, 2025
Comment on lines
-53
to
-54
| this._assetManager = assetManager | ||
| this._appManager = appManager |
Contributor
Author
There was a problem hiding this comment.
We're able to completely remove the dependency on the asset and app manager
joe-p
commented
Sep 23, 2025
Comment on lines
+5
to
+8
| import type { AppDeployer } from './app-deployer' | ||
| import type { AppManager } from './app-manager' | ||
| import type { AssetManager } from './asset-manager' | ||
| import type { AlgoSdkClients, ClientManager } from './client-manager' |
Contributor
Author
There was a problem hiding this comment.
We can remove remove the dependency on all of the managers from the AlgorandClient
joe-p
commented
Sep 23, 2025
Comment on lines
+13
to
+17
| clientManager?: Partial<InterfaceOf<ClientManager>> | ||
| accountManager?: Partial<InterfaceOf<AccountManager>> | ||
| appManager?: Partial<InterfaceOf<AppManager>> | ||
| assetManager?: Partial<InterfaceOf<AssetManager>> | ||
| appDeployer?: Partial<InterfaceOf<AppDeployer>> |
Contributor
Author
There was a problem hiding this comment.
Partial interfaces of the managers are passed in to AlgorandClient ctor
joe-p
commented
Sep 23, 2025
| return this | ||
| } | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
The static methods would live in a new "Builder" class. This would be the main difference as far as users are concerned. AlgorandClient.localnet() would become something along the lines of new AlgorandClientBuilder().localnet().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small spike to demonstrate my idea for making AlgorandClient more tree-shakeable