Skip to content

Comments

chore: Restyle status panel#180

Merged
tasosbit merged 1 commit intorelease/v1.5.0from
chore/style-status-panel
Nov 27, 2025
Merged

chore: Restyle status panel#180
tasosbit merged 1 commit intorelease/v1.5.0from
chore/style-status-panel

Conversation

@tasosbit
Copy link
Contributor

@tasosbit tasosbit commented Nov 27, 2025

ℹ Overview

Restyles the top (left) Status panel.

  • P2P label moves to the left column
  • "100 round average" label removed
  • TPS/RT swap rows, visually nicer flow
  • "Peers" padded left with spacing to force visual separation from left column (if they were close enough)

Before

1764255456

After

1764256339 1764256312

✅ Acceptance:

  • Pre-commit checks pass

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restyles the status panel UI to improve visual layout and clarity. The changes reorganize label positioning, remove redundant information, and swap row order for better visual flow.

  • P2P status label moved from right column to left column
  • Removed "100 round average" label
  • Swapped TPS and Round Time rows for improved visual hierarchy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +98 to +101
beginning = ""
end = ""
middle = strings.Repeat(" ", max(0, size-(lipgloss.Width(beginning)+lipgloss.Width(end)+2)))
row2 := lipgloss.JoinHorizontal(lipgloss.Left, beginning, middle, end)
Copy link

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculation of row2's middle spacing occurs before the beginning variable is set with the P2P information. This means row2 will always have the full width as spacing (since both beginning and end are empty strings at this point), and the P2P label won't affect the middle spacing calculation. The middle spacing calculation should be moved after line 109 where the beginning variable is properly set.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

row2 is supposed to be blank, so this is fine. But the same beginning, middle, and end variables are reused for every row, so I can see how it got confused.

tps = "--"
}
beginning = style.Blue.Render(" Round time: ") + roundTime
beginning = style.Blue.Render(" TPS: ") + tps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm never going to not see blue spaces before the TPS, lol

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say that, but they're not blue?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're blue. Daba dee daba day

Copy link
Collaborator

@nullun nullun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better! Thank you.

@tasosbit tasosbit merged commit dae5fe1 into release/v1.5.0 Nov 27, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants