refactor: let arc-4 method arg type check be done in ir layer

[boblat]

No description provided.

[engineering-ci]

Checking stubs for changes and corresponding version bump in origin/refactor/arg-check

Last puyapy release: v5.7.1
This branch stubs version: 3.4.0
Last released stubs version: 3.4.0
Main stubs version: 3.4.0

✅ Stub files unchanged
✅ Stub check passed!

[engineering-ci]

Name	Status	O0 bytes	O1 bytes	O2 bytes	O0 ops	O1 ops	O2 ops

[engineering-ci]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/puya
__main__.py	36	4	89%	45, 71–72, 78
arc32.py	89	15	83%	74, 96–97, 107–132
arc56.py	81	4	95%	285–287, 297
artifact_sorter.py	57	2	96%	32, 89
compile.py	210	7	97%	98–99, 173–174, 182, 343, 401
context.py	52	1	98%	39
errors.py	41	1	98%	59
log.py	269	56	79%	83, 93–94, 99–106, 121–129, 151, 187–188, 231–233, 236–238, 240, 253–269, 298, 304, 314–319, 322, 390–391, 448–450, 453–455, 484
main.py	42	7	83%	31, 52–57
parse.py	83	3	96%	31, 40, 50
program_refs.py	28	2	93%	45, 56
utils.py	226	14	94%	37, 196, 201–204, 222–224, 258, 265, 288, 290, 309, 348
src/puya/awst
function_traverser.py	336	3	99%	66, 76, 420
nodes.py	1319	63	95%	113, 117–120, 160, 164–167, 462, 527, 700, 769, 795, 853, 873, 896, 935, 980, 1009–1010, 1032, 1036, 1105, 1126, 1157–1158, 1185, 1188–1190, 1208, 1242, 1245, 1283, 1288, 1415, 1441, 1474, 1506, 1532, 1537, 1801, 1945, 1964, 2030, 2068, 2077, 2296, 2345, 2363, 2367, 2485, 2634, 2639, 2644, 2652, 2657, 2662, 2699–2700, 2710
serialize.py	76	12	84%	21–25, 49, 94–100, 117, 121
to_code_visitor.py	493	11	98%	149, 260, 297, 343, 380, 495–498, 690, 718, 722
txn_fields.py	101	1	99%	53
wtypes.py	381	8	98%	233, 375, 388, 399, 404–405, 446, 475
src/puya/awst/validation
base_invoker.py	47	4	91%	55, 62, 72–76
immutable.py	33	2	94%	29, 37
inner_transactions.py	196	1	99%	168
labels.py	31	4	87%	26–27, 38–41
src/puya/ir
_arc4_default_args.py	110	15	86%	63–64, 79, 92, 94, 96, 98, 100, 102, 108, 115, 136–137, 232, 239
contract_metadata.py	229	7	97%	56, 206–210, 308–314
arc4_router.py	259	5	98%	169, 233, 335, 353, 519
arc4_types.py	165	15	91%	46, 50, 54, 58, 70, 96, 103, 110, 117, 129, 135, 139, 151, 211, 233
avm_ops.py	324	1	99%	46
avm_ops_models.py	37	2	95%	15, 23
context.py	113	6	95%	79, 91, 98, 101, 103, 112
encodings.py	204	5	98%	230, 233, 239, 294, 298
main.py	224	14	94%	117, 126–132, 142–148, 174, 342–343, 355, 363
models.py	833	28	97%	211, 218, 413, 435, 459, 490, 556, 574, 578, 694–695, 819–820, 825, 831–835, 905, 935, 991, 1052, 1097, 1182, 1226, 1241, 1253, 1280, 1348–1349
mutating_register_context.py	87	3	97%	48–49, 51
op_utils.py	163	2	99%	212–219
ssa.py	151	2	99%	52–53
types.py	360	38	89%	57, 60, 63, 76, 81–83, 87–89, 129, 143, 182, 249, 252, 263, 272, 276, 279, 297, 303, 401–405, 516–517, 521, 524, 533, 543–544, 571, 580, 583, 586, 596–597, 614
visitor.py	195	5	97%	190, 299, 320, 326, 378
visitor_mutator.py	237	7	97%	89–92, 94, 209, 250
src/puya/ir/builder
_utils.py	89	5	94%	61, 63, 173, 177, 185
assignment.py	119	7	94%	63, 79, 190, 192–193, 220, 265
blocks.py	134	7	95%	55, 92–96, 158, 166, 231
bytes.py	70	14	80%	17–49, 138
callsub.py	109	10	91%	35–36, 57–60, 73, 118–122
dynamic_array.py	160	6	96%	81–82, 135–136, 172, 217
encoding_validation.py	71	1	99%	121
flow_control.py	104	2	98%	53, 57
iteration.py	239	5	98%	103–104, 120, 152, 230
itxn.py	723	55	92%	168–169, 171, 185, 223–224, 248–249, 362–365, 666, 784, 797, 840, 944–962, 993, 1082, 1106, 1121, 1128, 1132, 1168, 1180, 1184, 1198, 1210, 1216, 1222, 1226, 1230, 1250, 1314, 1324, 1328, 1332, 1348, 1360, 1388, 1394, 1398, 1402, 1406, 1424, 1435, 1446
main.py	745	50	93%	172, 297, 309–328, 338–340, 407, 431, 455, 479–480, 504, 530, 572, 577–578, 589–590, 681, 754, 779–780, 812, 847, 928, 993, 1092–1096, 1179, 1247, 1250, 1403, 1429, 1457–1458, 1609, 1629, 1684–1686
sequence.py	133	6	95%	186–191, 212–215, 230–231
storage.py	208	5	98%	117, 335–339, 351
src/puya/ir/builder/aggregates
arc4_codecs.py	321	25	92%	58, 94, 147–148, 203, 271, 324, 337, 355, 398, 416, 432–434, 448–450, 524, 541, 543, 560–561, 576–577, 606
main.py	108	3	97%	122, 148, 162
sequence.py	156	1	99%	144
src/puya/ir/destructure
coalesce_locals.py	144	21	85%	198, 209, 213–224, 230–231, 246–251
critical_edges.py	32	1	97%	24
parcopy.py	72	1	99%	80
src/puya/ir/optimize
_call_graph.py	32	1	97%	42
_utils.py	54	1	98%	57
add_box_extract_replace.py	279	5	98%	235–236, 240, 276, 516
assignments.py	114	4	96%	48, 168, 184–185
compiled_reference.py	101	5	95%	56, 87, 168–173
constant_propagation.py	71	1	99%	90
control_op_simplification.py	77	1	99%	170
inlining.py	244	11	95%	34–43, 47, 54, 417, 421, 425, 435, 439
inner_txn.py	36	2	94%	49–50
intrinsic_simplification.py	809	41	95%	268, 514, 545, 556–557, 625–626, 647, 752, 833, 864–893, 1244–1246, 1325, 1351, 1353, 1426, 1440, 1471, 1477, 1479, 1481, 1486, 1488, 1490, 1568
repeated_loads_elimination.py	155	2	99%	156, 173
src/puya/ir/validation
_base.py	30	1	97%	28
compile_reference_validator.py	20	2	90%	24, 30
min_avm_version_validator.py	15	4	73%	16–20
op_run_mode_validator.py	19	1	95%	29
slot_reservation.py	18	1	94%	20
src/puya/mir
aligned_writer.py	63	2	97%	21, 61
builder.py	211	25	88%	129–131, 159–161, 180, 183, 186, 189, 192, 195, 198, 201, 204, 260, 267, 407, 410, 413, 416, 419, 422, 425, 428
main.py	77	1	99%	37
models.py	499	4	99%	120, 255, 321, 727
output.py	61	1	98%	20
visitor.py	86	1	99%	175
src/puya/mir/stack_allocation
f_stack.py	95	3	97%	58–67
l_stack.py	117	1	99%	71
peephole.py	41	3	93%	38, 40, 43
x_stack.py	203	3	99%	33, 331–335
src/puya/teal
builder.py	200	2	99%	74, 114
models.py	470	1	99%	461
stack_manipulations.py	31	1	97%	42
src/puya/teal/optimize
constant_block.py	93	4	96%	43, 126, 163, 180
constant_stack_shuffling.py	94	9	90%	54–55, 77–78, 94–100
main.py	175	4	98%	145, 204, 231–232
peephole.py	137	2	99%	170, 295
repeated_rotations.py	51	5	90%	16, 52–55
repeated_rotations_search.py	90	6	93%	35, 41–42, 58, 68–69
src/puya/ussemble
assemble.py	201	3	99%	253, 273, 317
models.py	26	1	96%	16
op_spec_models.py	22	1	95%	20
src/puyapy
__main__.py	44	6	86%	161, 166–171, 212, 221
client_gen.py	110	11	90%	59–60, 78–82, 86, 200, 207–208, 228
compile.py	91	13	86%	46, 62, 73, 77, 137–138, 146–149, 158–161
find_sources.py	97	4	96%	25, 46, 105, 124
interpreter_data.py	18	2	89%	32–33
models.py	86	1	99%	56
parse.py	270	35	87%	115–120, 179, 189, 197, 209–210, 226–228, 239–244, 252–257, 261, 436, 440–441, 473–476, 480–481, 494–496, 501
template.py	32	8	75%	10–11, 18–19, 27–28, 34, 37
src/puyapy/awst_build
arc4_client.py	101	26	74%	45–49, 57, 69, 75, 79, 96, 108, 111–112, 118, 121, 124, 130, 133, 136–141, 144, 147, 150, 153, 156, 159, 162, 165
arc4_client_gen.py	134	8	94%	30, 89–90, 100, 102, 117–118, 188
arc4_decorators.py	247	51	79%	45, 90–91, 98–100, 111–115, 123–125, 146–148, 151, 180, 188, 202, 204, 237, 250–251, 265–266, 280–281, 288, 291–297, 302, 309, 330, 338, 342, 352–356, 372, 374, 377–378, 387, 390–391, 393
arc4_utils.py	115	18	84%	36, 38, 55, 79, 84, 86, 90–93, 95–98, 162, 169, 183, 199–202, 211
base_mypy_visitor.py	155	28	82%	59, 69, 92–100, 167–173, 191, 199–212, 226, 228, 230, 281, 285, 289, 291, 298–318
context.py	271	61	77%	57, 60, 70–71, 89–90, 130, 177, 180–181, 183, 235, 240, 246–250, 257, 266, 268, 271–273, 275, 282, 284, 294–307, 319, 333, 336–348, 366, 384, 409, 418–424
contract.py	328	31	91%	123, 175, 204–208, 248, 250, 254, 258, 266, 278, 280, 350, 353, 365, 373, 376, 379, 382, 385, 388, 391, 394, 397, 490–494, 543–547, 621–625, 683, 709
intrinsic_factory.py	26	2	92%	67–69
intrinsic_models.py	49	1	98%	55
main.py	42	1	98%	41
module.py	428	61	86%	139, 159, 165–182, 199–200, 207, 216–217, 224–228, 250, 279, 299–300, 311, 333–336, 346–348, 354, 371–374, 387, 421, 450–451, 472–473, 529–530, 556, 567, 570, 576, 589, 595, 601, 621, 641, 646, 650, 659–663, 755, 763, 765
pytypes.py	669	67	90%	87, 97–99, 104, 111, 116–118, 122–124, 151–152, 191, 205–211, 234, 258, 300, 338–340, 369, 436, 445, 464, 482, 486, 601–602, 686–688, 702–703, 770–771, 875, 886–887, 925–926, 973–974, 979, 1048–1049, 1072–1073, 1246–1247, 1282–1283, 1305–1306, 1334, 1362, 1398–1400, 1440, 1450–1451
subroutine.py	640	41	94%	184–185, 282, 308–309, 327, 344, 369, 377, 388, 421–424, 537–538, 593, 726, 737, 739, 748, 766, 769, 801, 807, 868, 876–879, 885, 936, 941, 944–950, 1041, 1061, 1217, 1257, 1283, 1299–1300, 1309
utils.py	203	28	86%	30, 47–51, 79–80, 102, 141–142, 144, 188–189, 240, 248, 253, 266–270, 275–278, 285, 329–332
src/puyapy/awst_build/eb
_base.py	127	15	88%	52, 57–59, 64, 71, 80–82, 143, 184, 189, 199, 210, 224–226
_bytes_backed.py	48	2	96%	30–31
_expect.py	122	17	86%	25, 36, 85–88, 107, 160–161, 219–222, 232–235
_literals.py	156	34	78%	44, 65, 77, 96, 125, 142, 156–160, 164, 168–174, 184–198, 203
_type_registry.py	43	3	93%	279–280, 293
utils.py	62	3	95%	36–38, 108
arc4_client.py	30	3	90%	36, 42, 63
biguint.py	105	6	94%	57, 101, 142, 158–159, 161
binary_bool_op.py	105	3	97%	153, 161, 171
bool.py	55	9	84%	38–42, 58, 69, 82, 96
bytes.py	173	16	91%	102–103, 130–131, 136–137, 143–144, 147, 155, 233, 271, 292–293, 313–314
compiled.py	70	9	87%	85–89, 126–130, 153
conditional_literal.py	133	34	74%	97, 101, 161, 165–168, 177–179, 202–205, 214, 218, 222–225, 240–252, 261–262, 273–276
contracts.py	77	8	90%	55, 61, 63, 73, 99, 109, 111, 116
dict.py	27	5	81%	24, 32–34, 38
ensure_budget.py	31	1	97%	46
fixed_bytes.py	274	11	96%	110–111, 142, 250, 335, 412, 464, 516, 522, 586–587
interface.py	91	2	98%	317–319
intrinsics.py	120	8	93%	55–56, 70, 91, 98, 111, 118, 210
log.py	43	4	91%	45–46, 51, 60
logicsig.py	15	1	93%	25
none.py	27	4	85%	17, 27–28, 37
size_of.py	25	3	88%	31–33
string.py	144	13	91%	71, 115–116, 135, 140, 183, 190, 194, 206, 280–282, 302
subroutine.py	80	16	80%	46, 50–53, 68, 71–78, 93, 101–102, 104–107, 112
template_variables.py	37	2	95%	29, 57
tuple.py	338	14	96%	87, 94, 135, 154, 203, 209, 257, 350–351, 470, 546, 557–558, 621
uint64.py	108	5	95%	57, 118–119, 167–168
uint64_enums.py	40	2	95%	40, 45
unsigned_builtins.py	155	22	86%	73, 80, 104, 128, 132, 136, 140, 148, 152, 156, 160, 164, 174, 178, 184, 195, 201, 207, 246, 278, 290, 302
src/puyapy/awst_build/eb/abi_call
_utils.py	178	8	96%	57, 143, 150–151, 197, 286, 310, 385
arc4.py	158	11	93%	151, 165–166, 241–249, 334–335
itxn.py	89	2	98%	104, 202
src/puyapy/awst_build/eb/arc4
_base.py	105	5	95%	183–186, 197, 227–228
_utils.py	101	9	91%	44, 55, 60, 86, 109–113, 145, 149, 153
address.py	73	2	97%	56, 115
bool.py	60	1	98%	42
dynamic_array.py	122	9	93%	109–110, 128, 152, 206, 221–222, 225–228
dynamic_bytes.py	68	4	94%	47, 98–100
emit.py	53	2	96%	40–43
string.py	100	7	93%	54–55, 105, 126, 131–134
struct.py	82	1	99%	54
tuple.py	92	12	87%	51–53, 91–94, 97–98, 137–140, 145, 170
ufixed.py	74	2	97%	51, 110
uint.py	96	2	98%	101–106
src/puyapy/awst_build/eb/reference_types
account.py	82	1	99%	179
application.py	45	1	98%	39
asset.py	65	1	98%	47
src/puyapy/awst_build/eb/storage
_storage.py	108	20	81%	58, 66, 70, 74, 78, 82, 86, 90, 94, 104, 108, 112, 116, 122, 133, 139, 145, 157–159
_value_proxy.py	55	3	95%	42, 50, 54
box.py	113	1	99%	174
box_map.py	164	2	99%	199, 265
box_ref.py	111	17	85%	76–80, 89–93, 103, 111, 127, 135, 148, 153–162
global_state.py	127	6	95%	103–104, 113–114, 163–164
local_state.py	137	11	92%	98–99, 103, 150, 154, 158, 168, 172, 196, 253, 277
src/puyapy/awst_build/eb/transaction
base.py	39	2	95%	22, 42
inner.py	54	2	96%	96–97
inner_params.py	88	5	94%	65, 77, 81, 169, 171
itxn_args.py	60	1	98%	72
src/puyapy/lsp
__main__.py	17	17	0%	1–44
analyse.py	268	191	29%	58–70, 76–183, 186–197, 201–216, 226–246, 249, 252–254, 265–281, 288–332, 349–373, 381, 385–386, 395–399, 404–411, 434–449, 461, 465, 467, 473, 482–487, 491
log.py	44	44	0%	1–89
server.py	133	82	38%	62–70, 74–79, 86–136, 153–155, 158–162, 165–172, 179–197, 200, 203–208, 218–220
src/puyapy/validation
arc4_copy.py	130	2	98%	35, 39
TOTAL	30655	2036	93%

Tests	Skipped	Failures	Errors	Time
1391	3 💤	0 ❌	0 🔥	10m 40s ⏱️