Conversation
|
Checking stubs for changes and corresponding version bump in origin/assembly-report Last puyapy release: v5.7.1 💡 Stub version change: 3.4.0 -> 3.5.0 |
|
|
The artifacts are on their own commit so reviewers can diff review the relevant part by selecting a smaller commit-range. |
|
iglosiggio
force-pushed
the
assembly-report
branch
from
8a826d5 to
c60a592
Compare
iglosiggio
force-pushed
the
assembly-report
branch
from
b67fb97 to
605e2a7
Compare
|
I had some changes that I forgot to push 🤦 sorry for the delay. |
iglosiggio
force-pushed
the
assembly-report
branch
from
605e2a7 to
c91628f
Compare
test_cases/abi_routing/out/CustomApproval.approval.assembly-report
Outdated
Show resolved
Hide resolved
src/puyapy/__main__.py
Outdated
| @@ -56,6 +56,7 @@ def puyapy( | |||
| ] = None, | |||
| log_level: Annotated[LogLevel, cyclopts.Parameter(group=_outputs_group)] = LogLevel.info, | |||
| output_teal: _OutputToggle = True, | |||
| output_assembly_report: _OutputToggle = True, | |||
There was a problem hiding this comment.
Are we sure we want to output this by default? The source map is output by default since it's consumed by debugging, but this report is probably going to be used only in more specific circumstances?
There was a problem hiding this comment.
Discussed it w/@Argimirodelpozo and you are right. Better to leave it false by default :)
There was a problem hiding this comment.
| output_assembly_report: _OutputToggle = True, | |
| output_assembly_report: _OutputToggle = False, |
| if op_loc is None: | ||
| op_loc_str = "" | ||
| elif op_loc.line != op_loc.end_line: | ||
| op_loc_str = repr(op_loc) |
There was a problem hiding this comment.
Multi-line locations source is not outputted? And it doesn't change last_location either?
src/puya/teal/output.py
Outdated
| src = None | ||
| last_location_indent = 0 |
There was a problem hiding this comment.
So these are initialise once, applying across block boundaries, but last_location is reset per block?
Note: this will be buggy for ligatures and/or grapheme clusters. But the fix was simple enough :)
iglosiggio
force-pushed
the
assembly-report
branch
from
6ee7cae to
b82fe28
Compare
3 participants
Proposed Changes
--output-assembly-reportflag (default:True)This would close #642.