Open
Conversation
ori-shem-tov
reviewed
Feb 5, 2025
| env: | ||
| REPO: ${{ github.repository }} | ||
| PR_NO: ${{ github.event.pull_request.number }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
might need to use actions/create-github-app-token
There was a problem hiding this comment.
nvm, I think I'm wrong. you're just getting the branch name so secrets.GITHUB_TOKEN should work
HashMapsData2Value
added a commit
that referenced
this pull request
Mar 5, 2025
# This is the 1st commit message: feat: adds Admin Page (roles, kyc, cohort) and become-proposer # This is the commit message #2: chore(storybook): starting to clean up storybook tests and other misc # This is the commit message #3: chore: removed storybook visual tests temporarily on proposal card & added list-none to li card # This is the commit message #4: fix(storybook): cleaned up storybook tests # This is the commit message #5: feat: adds KMD as a wallet # This is the commit message #6: feat: block view of KYC for non KYC provider # This is the commit message #7: fix: Adjust to Algokit Utils v7 and latest xgov-beta-sc commit # This is the commit message #8: chore: change name of boolean controlling view of Admin # This is the commit message #9: feat: introduce roles, refactor # This is the commit message #10: feat: checkpoint working way to update roles from admin page # This is the commit message #11: feat: introduces a Initialize Page and a Registry Contract context # This is the commit message #12: feat: improves UX # This is the commit message #13: checkpoint # This is the commit message #14: checkpoint # This is the commit message #15: chore: remove unnecessary blur # This is the commit message #16: fix: Admin page only shown to signed in role-holder # This is the commit message #17: fix: refactor how roles are pulled in and propagated through state management # This is the commit message #18: feat: working become page with email verification and algo address verification # This is the commit message #19: feat: return to basic form of become-proposer
Collaborator
|
@HashMapsData2Value do you recall the context here? Why did we want this? |
Contributor
Author
I think we had a problem with the previews being created for each branch but then never being deleted after tickets being closed? Not sure if it still persists or that it was a big deal, given that we never got back to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ Overview
📝 Related Issues
✅ Acceptance:
npm test:covpasses