Add robust response validation and token config support #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces consistent None and truncation checks for model responses across all major modules, improving error handling and fallback behavior. Adds support for max_completion_tokens in request configuration, with priority over max_tokens, and propagates this through plugin and server layers. Enhances logging for truncated or empty responses and ensures backward compatibility for token limit parameters.
Added explicit checks to ensure that valid completions are generated in both best_of_n_sampling and mixture_of_agents functions. If no completions are available, the functions now raise exceptions or return error messages, improving robustness against provider failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces consistent None and truncation checks for model responses across all major modules, improving error handling and fallback behavior. Adds support for max_completion_tokens in request configuration, with priority over max_tokens, and propagates this through plugin and server layers. Enhances logging for truncated or empty responses and ensures backward compatibility for token limit parameters.
fixes #262 and fixes #264