Skip to content

bugfix : prevent creation of duplicate users #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bugfix : prevent creation of duplicate users #58

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f2fe3
bugfix : prevented creation of duplicate users
medaminefracso Oct 23, 2023
f041214
fixed : fetch user once
medaminefracso Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/main/java/com/alibou/security/auth/AuthenticationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,18 @@ public class AuthenticationService {
private final AuthenticationManager authenticationManager;

public AuthenticationResponse register(RegisterRequest request) {
var user = User.builder()
.firstname(request.getFirstname())
.lastname(request.getLastname())
.email(request.getEmail())
.password(passwordEncoder.encode(request.getPassword()))
.role(request.getRole())
.build();
var savedUser = repository.save(user);
// Check if the given user exists in database
boolean isPresent = repository.findByEmail(request.getEmail()).isPresent();
var user = isPresent
? repository.findByEmail(request.getEmail()).get()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are fetching the same data twice from DB?

: User.builder()
.firstname(request.getFirstname())
.lastname(request.getLastname())
.email(request.getEmail())
.password(passwordEncoder.encode(request.getPassword()))
.role(request.getRole())
.build();
var savedUser = isPresent ? user : repository.save(user);
var jwtToken = jwtService.generateToken(user);
var refreshToken = jwtService.generateRefreshToken(user);
saveUserToken(savedUser, jwtToken);
Expand Down