Open
Conversation
added 6 commits
September 1, 2023 17:25
YunZZY
reviewed
Oct 17, 2023
lib/common/bucket/dataIndex.ts
Outdated
| MetaQuery: { | ||
| NextToken: queryParam.nextToken, | ||
| MaxResults: queryParam.maxResults, | ||
| Query: JSON.stringify(queryParam.query), |
Collaborator
There was a problem hiding this comment.
这里直接转成JSON字符串了，里面的key不需要处理成大写吗
test/browser/browser.test.js
Outdated
| }); | ||
| }); | ||
|
|
||
| // oss server 不支持跨域 大概要到9月30号才上生产支持 跨域，后端是：云仁 |
Collaborator
There was a problem hiding this comment.
现在应该可以了，这里的case加一下，要保证所有的参数都有设置一下，保证覆盖率
test/node/bucket.test.js
Outdated
| it('doMetaQuery()', async () => { | ||
| try { | ||
| const queryParam = { | ||
| query: { operation: 'and', subQueries: [{ Field: 'Size', Value: '1048576', Operation: 'lt' }] } |
test/node/bucket.test.js
Outdated
| it('doMetaQuery() Aggregations', async () => { | ||
| try { | ||
| const queryParam = { | ||
| query: { operation: 'and', subQueries: [{ Field: 'Size', Value: '1048576', Operation: 'lt' }] }, |
Collaborator
There was a problem hiding this comment.
参数设置全一些，subQueries类型这里对不上，改一下
|
没人了吗？ 阿里这个库是要弃用了吗？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.