Skip to content

fix(components/execd): fix the issue where command init message arrives before memory state, causing interrupt to throw a 404 error #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hittyt merged 1 commit into from
Dec 24, 2025
Merged

fix(components/execd): fix the issue where command init message arrives before memory state, causing interrupt to throw a 404 error #33

hittyt merged 1 commit into from
Dec 24, 2025

Conversation

@Pangjiping
Copy link
Collaborator

@Pangjiping Pangjiping commented Dec 23, 2025 •
edited
Loading

Summary

  • Fix the issue where command init event arrives before memory state, causing interrupt to throw a 404 error
  • Now we write memory state first, then send command initevent

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@Pangjiping
fix(components/execd): fix the issue where command init message arriv…
9b76bef 
…es before memory state, causing interrupt to throw a 404 error
@Pangjiping Pangjiping added the bug Something isn't working label Dec 23, 2025
@jwx0925
Copy link
Collaborator

jwx0925 commented Dec 24, 2025

Has any unit-tests to cover this PR change？

hittyt
hittyt approved these changes Dec 24, 2025
View reviewed changes
Copy link
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit 1f4b978 into alibaba:main Dec 24, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hittyt hittyt hittyt approved these changes

@jwx0925 jwx0925 Awaiting requested review from jwx0925

@ninan-nn ninan-nn Awaiting requested review from ninan-nn

+1 more reviewer

@hellomypastor hellomypastor hellomypastor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pangjiping @jwx0925 @hittyt @hellomypastor