feat(pool): add scaleStrategy to control scaling behavior#604
Merged
Spground merged 6 commits intoalibaba:mainfrom Mar 30, 2026
Merged
feat(pool): add scaleStrategy to control scaling behavior#604Spground merged 6 commits intoalibaba:mainfrom
Spground merged 6 commits intoalibaba:mainfrom
Conversation
- Introduced ScaleStrategy with MaxUnavailable option in PoolSpec to limit unavailable pods during scaling - Enforced maxUnavailable constraint in pool controller to control concurrent pod creation - Default maxUnavailable set to 25% if not specified, with a minimum of 1 pod - Added utility functions to calculate maxUnavailable and count not ready pods - Updated CRD schema to include scaleStrategy field with proper validation - Generated deepcopy methods for ScaleStrategy type - Added comprehensive e2e tests to verify scaling behavior with various maxUnavailable settings including default, percentage, and absolute number
# Conflicts: # kubernetes/internal/controller/pool_controller.go
fengcone
requested review from
Generalwin,
Pangjiping,
Spground,
hittyt,
kevinlynx and
ninan-nn
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc3b6f13a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist