-
Notifications
You must be signed in to change notification settings - Fork 17
feat(specs): introduce batch-sandbox API with pagination and refined … #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| type: integer | ||
| minimum: 0 | ||
| description: Replica index within the batch | ||
| sandboxId: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is responsible for generating sandbox-id? The k8s operator or api service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the k8s cluster mode, sandbox-id should be generated by the operator.
api server is responsible for wrapping it into the BatchSandboxMember object.
| description: Batch creation timestamp | ||
| required: [id, status, replica, poolRef, createdAt] | ||
|
|
||
| BatchSandbox: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeout. shall we addtimeoutfield forBatchSandboxlike singleSandboxtimeoutfiled used for TTL.- how about we also support
resource_limitsfield to specify container resource. Use case example: user didn't needpooling, just declare list ofimage,env,commandandargsinsandbox_override ` field, in this case, the system should create batch of Pods directly using user's declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeoutfield is added with description.- I recommend omitting the resource_limits field to maintain API simplicity. Since batch provisioning relies on
pre-warmed buffers within a Pool for instant startup, allowing ad-hoc resource overrides alongside a mandatory poolRef creates ambiguity and undermines the performance benefits of the pool.
|
After further discussion, we've realized that the batch-sandbox API isn't strictly |
…overrides
Summary
Refines the OpenSandbox Batch Sandbox API specification (specs/batch-sandbox.yml) to improve scalability for high-volume provisioning and ensure architectural consistency across the platform.
Testing
Breaking Changes
Checklist