refactor(cache): move rwlock from LruEntry to FileStore, to reduce memory usage#1149
Merged
EricHuangqx merged 3 commits intoalibaba:release/0.9from Mar 20, 2026
Merged
Conversation
Collaborator
|
given that you bind the life-cycle of rwlock to FileStore, is it possible to move the rwlock from LruEntry to FileStore? |
xiaoyang-hhh
force-pushed
the
cache_optimize
branch
4 times, most recently
from
87eef3f to
b32422d
Compare
xiaoyang-hhh
force-pushed
the
cache_optimize
branch
from
b32422d to
8eab878
Compare
lihuiba
reviewed
Mar 19, 2026
| int err; | ||
| auto lruEntry = static_cast<QuotaLruEntry*>(fileIter->second.get()); | ||
|
|
||
| auto cacheStore = static_cast<FileCacheStore*>(open(filePath, O_RDWR, 0644)); |
Collaborator
There was a problem hiding this comment.
DEFER(cacheStore->release())
| bool flags_dir_delete = false; | ||
|
|
||
| auto cacheStore = static_cast<FileCacheStore*>(open(fileName, O_RDWR, 0644)); | ||
| { |
Collaborator
There was a problem hiding this comment.
DEFER(cacheStore->release())
| } | ||
| int err = 0; | ||
| auto cacheStore = static_cast<FileCacheStore*>(open(filePath, O_RDWR, 0644)); | ||
| { |
Collaborator
There was a problem hiding this comment.
DEFER(cacheStore->release())
lihuiba
changed the title
EricHuangqx
approved these changes
Mar 20, 2026
photonlibos
pushed a commit
that referenced
this pull request
Mar 20, 2026
…mory usage (#1149) * refactor(cache): lazy initialize rwlock to reduce memory usage * fix build * use defer to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change LruEntry::rw_lock_ from direct member to std::unique_ptr for lazy initialization in Full File Cache:
This reduces memory usage when there are many cache files, but only a small number of them are being read or written at any moment.