Skip to content
This repository was archived by the owner on Jul 16, 2024. It is now read-only.

Modify code with refactors#229

Open
francestang1117 wants to merge 1 commit intoalibaba:masterfrom
francestang1117:refactor
Open

Modify code with refactors#229
francestang1117 wants to merge 1 commit intoalibaba:masterfrom
francestang1117:refactor

Conversation

@francestang1117
Copy link
Copy Markdown

Hi, I refactored some code. Hope you could check it. Thank you.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 7, 2023

CLA assistant check
All committers have signed the CLA.

@linux-china
Copy link
Copy Markdown
Collaborator

@francestang1117 是不是 RSocketEncodingFacade.getInstance();更好一些?

 - protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance();
 + protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance(new RSocketEncodingFacadeImpl());

@francestang1117
Copy link
Copy Markdown
Author

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

@linux-china
Copy link
Copy Markdown
Collaborator

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

好的,我看一下这个问题,看能否更好地修复一下。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants