perf(reactive): optimize arrayField performance, achieving precise rendering with array transposition#4327
Open
voderl wants to merge 6 commits intoalibaba:formily_nextfrom
Open
perf(reactive): optimize arrayField performance, achieving precise rendering with array transposition#4327voderl wants to merge 6 commits intoalibaba:formily_nextfrom
voderl wants to merge 6 commits intoalibaba:formily_nextfrom
Conversation
|
|
4ac6512 to
55791d1
Compare
…ctly trigger upstream reaction
55791d1 to
450a6f8
Compare
…to optimize render performance
450a6f8 to
ecb5789
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
masterorformily_next.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.Please do not delete the above content
What have you changed?
ArrayField does not implement precise rendering, any array state transition will cause all children re-rendering.
When the array is large, it is not possible to render accurately by key, resulting in poor performance.
In this MR, I changed the reaction action of computed to ensure that the computed value will not directly trigger the upstream reaction, but only trigger upstream reaction when computed value has changed.
At the same time, the performance of releasing dependencies during reaction execution is also very low. When there are a large number of reactions and computed values, the performance is very poor, and the degradation is very serious as the number increases. The logic of re-collecting dependencies in reaction has been optimized.
All test cases passed.
Therefore, we can achieve a significant performance improvement on arrayField.
Performance compare sandbox:
https://codesandbox.io/p/sandbox/voder-formily-performance-forked-2wlfmc?file=%2Fformily-array-field.tsx%3A26%2C9