fix: Fix linting errors and test setup for instrumentation-loongsuite… #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
123liuziming,
Cirilla-zmh and
ralf0131
sipercai
force-pushed
the
fix/instrumentation-loongsuite-linting
branch
from
e384b46 to
e4a3645
Compare
Cirilla-zmh
added
the
Skip Changelog
Collaborator
|
@sipercai Could you fix the failing checking? |
Collaborator
|
@sipercai Just rebase the main branch and these PR checks may be resolved. |
sipercai
force-pushed
the
fix/instrumentation-loongsuite-linting
branch
from
e4a3645 to
d862393
Compare
Collaborator
|
@sipercai Please rebase the latest main and try to fix the lint failure of PLC0415. |
… packages - Fix linting errors (PLC0415, A001/A002, E501, F401, F841, I001) in: - loongsuite-instrumentation-agentscope: variable shadowing, import order, unused variables - loongsuite-instrumentation-agno: import order, variable shadowing, dictionary iteration - loongsuite-instrumentation-langchain: long line URLs, import order - Fix test setup issues: - Add opentelemetry-instrumentation dependency to agno package - Add test dependencies (openai, yfinance) for agno tests - Add conftest.py for agentscope tests to configure Python path - Fix import paths and version detection utilities - Break down long URL comments into multiple lines to comply with line length limits Change-Id: I746644dabeed4f0bd32603ba2c96fb712501d689 Co-developed-by: Cursor <[email protected]>
sipercai
force-pushed
the
fix/instrumentation-loongsuite-linting
branch
from
d862393 to
f2f79a2
Compare
Change-Id: If6c5fe8b0c0a1e508cec96e6254c5143db69b323 Co-developed-by: Cursor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes linting errors and test setup issues in the
instrumentation-loongsuitepackages to ensure code quality and testability.Fixes #63
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e precommit
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.