fix: correct timestamp calculation in dify instrumentation#74
Merged
Cirilla-zmh merged 1 commit intoalibaba:mainfrom Dec 3, 2025
Merged
fix: correct timestamp calculation in dify instrumentation#74Cirilla-zmh merged 1 commit intoalibaba:mainfrom
Cirilla-zmh merged 1 commit intoalibaba:mainfrom
Conversation
github-actions
bot
requested review from
123liuziming,
Cirilla-zmh and
ralf0131
minimAluminiumalism
force-pushed
the
main
branch
from
b1522ee to
f240663
Compare
Collaborator
|
Thank you for this PR! @hieheihei Could you please help review this? |
Cirilla-zmh
added
instrumentaion
Collaborator
|
LGTM |
Collaborator
|
Please fix the CI failure before we merge this PR. |
ralf0131
approved these changes
Dec 3, 2025
Collaborator
|
This PR may not need a change log, let's ignore it. Thanks for your work! @minimAluminiumalism |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicate microsecond calculation. The
datetime.timestamp()method already includes microseconds in its decimal portion.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.