Skip to content

Conversation

@minimAluminiumalism
Copy link
Contributor

@minimAluminiumalism minimAluminiumalism commented Dec 2, 2025

Description

Remove duplicate microsecond calculation. The datetime.timestamp() method already includes microseconds in its decimal portion.

Clipboard_Screenshot_1764649023

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Cirilla-zmh
Copy link
Collaborator

Thank you for this PR!

@hieheihei Could you please help review this?

@Cirilla-zmh Cirilla-zmh requested a review from hieheihei December 2, 2025 08:23
@Cirilla-zmh Cirilla-zmh added instrumentaion The instrumentation label represents issues related to instrumentation. genai The genai label represents issues related to generative AI. labels Dec 2, 2025
@hieheihei
Copy link
Collaborator

LGTM

@ralf0131
Copy link
Collaborator

ralf0131 commented Dec 3, 2025

Please fix the CI failure before we merge this PR.

@Cirilla-zmh Cirilla-zmh added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 3, 2025
@Cirilla-zmh
Copy link
Collaborator

This PR may not need a change log, let's ignore it. Thanks for your work! @minimAluminiumalism

@Cirilla-zmh Cirilla-zmh merged commit 48c8320 into alibaba:main Dec 3, 2025
658 of 661 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

genai The genai label represents issues related to generative AI. instrumentaion The instrumentation label represents issues related to instrumentation. Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants