Skip to content

Conversation

@XenoAmess
Copy link

@XenoAmess XenoAmess commented Mar 26, 2020

in short, these fixs are for suiting idea 2020.1 Beta, also includes some bugfix and Deprecated codes migration.
I use p3c myself, and recently it looks buggy and print lots of stacktrace. It is unacceptable, so I come here to see what goes wrong.
Notice that I only fully tested the codes on 2020.1 beta(and done some very rough tests on older versions), so please retest it on older version by yourself when you get the pr.

1.(severe)

fix a bug that will throw a Throwable.
this bug is because you use ActionManager.getInstance() in CommonSettingsApplicationComponent, and ActionManager.getInstance() cannot be called in such state, thus the following codes will never run and a Throwable thrown.
As Component is Deprecated for a long time, I decide to migrate this class to StartupActivity, which is a far better option.

2.(light)

AccessToNonThreadSafeStaticFieldFromInstanceInspectionBase is deprecated and change it to AccessToNonThreadSafeStaticFieldFromInstanceInspection

3.(medium)

p3c-cmd/pom.xml has a duplicated plugin.
you plugin it two times and I do not see any value in doing so.
just deleted it.

4.(severe)

ArrayEqualityFix.getFamilyName() is totally wrong.
It is a dead recursion.
Fixed it.

5.(light)

update gradle_jetbrains_version and kotlin_version.

6.(suggest)

test it and release as soon as possible.

Also I see you are hiring people...kind of impressive.

in short, these fixs are for suiting idea 2020.1 Beta, also includes some bugfix and Deprecated codes migration.
I use p3c myself, and recently it looks buggy and print lots of stacktrace. It is unacceptable, so I come here to see what goes wrong.
Notice that I only fully tested the codes on 2020.1 beta(and done some very rough tests on older versions), so please retest it on older version by yourself when you get the pr.
1.(severe)
fix a bug that will throw a Throwable.
this bug is because you use ActionManager.getInstance() in CommonSettingsApplicationComponent, and ActionManager.getInstance() cannot be called in such state, thus the following codes will never run and a Throwable thrown.
As Component is Deprecated for a long time, I decide to migrate this class to StartupActivity, which is a far better option.
2.(light).AccessToNonThreadSafeStaticFieldFromInstanceInspectionBase is deprecated and change it to AccessToNonThreadSafeStaticFieldFromInstanceInspection
3.(medium)
p3c-cmd/pom.xml has a duplicated plugin.
you plugin it two times and I do not see any value in doing so.
just deleted it.
4.(severe)
ArrayEqualityFix.getFamilyName() is totally wrong.
It is a dead recursion.
Fixed it.
5.(light)
update gradle_jetbrains_version and kotlin_version.
6.(suggest)
test it and release as soon as possible.
Also I see you are hiring people...kind of impressive.
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2020

CLA assistant check
All committers have signed the CLA.

@XenoAmess
Copy link
Author

I will close this pr because there are some more updates/bugfix.
I have created a third party maintenance fork for dealing with them.
And this pr itself has a bug (is fixed in my TPM), which will cause break on idea versions earlier than 2020.
will open a new pr at: #660
In that pr I will link my TPM's release branch into your master branch, you can chose the fixes you interested in and merge them.

@XenoAmess XenoAmess closed this Apr 10, 2020
@XenoAmess XenoAmess deleted the master branch April 30, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants