fix

Author: zjw1111

src/paimon/common/fs/file_system_test.cpp

@@ -1017,7 +1017,7 @@ TEST_P(FileSystemTest, TestMkdir2) {
     }
 }
 
-// test for create multi dir such as "partition1/bucket1" and "partition1/bucket2"
+// test for create multi dir such as "/table/partition1/bucket1" and "/table/partition1/bucket2"
 TEST_P(FileSystemTest, TestMkdirMultiThread) {
     uint32_t runs_count = 10;
     uint32_t thread_count = 10;
@@ -1042,7 +1042,7 @@ TEST_P(FileSystemTest, TestMkdirMultiThread) {
     }
 }
 
-// test for create multi dir such as "partition1" and "partition1"
+// test for create multi dir such as "/table/partition1" and "/table/partition1"
 TEST_P(FileSystemTest, TestMkdirMultiThread2) {
     uint32_t runs_count = 10;
     uint32_t thread_count = 10;
@@ -1055,8 +1055,28 @@ TEST_P(FileSystemTest, TestMkdirMultiThread2) {
         for (uint32_t thread_idx = 0; thread_idx < thread_count; thread_idx++) {
             futures.push_back(Via(executor.get(), [this, &uuid]() -> void {
                 std::string dir_path = PathUtil::JoinPath(test_root_, uuid);
-                // ASSERT_OK_AND_ASSIGN(bool is_exist, fs_->Exists(dir_path));
-                // ASSERT_FALSE(is_exist);
+                ASSERT_OK(fs_->Mkdirs(dir_path));
+                ASSERT_OK_AND_ASSIGN(bool is_exist, fs_->Exists(dir_path));
+                ASSERT_TRUE(is_exist);
+            }));
+        }
+        Wait(futures);
+    }
+}
+
+// test for create multi dir such as "partition1" and "partition1" (relative path)
+TEST_P(FileSystemTest, TestMkdirMultiThread3) {
+    uint32_t runs_count = 10;
+    uint32_t thread_count = 10;
+    auto executor = CreateDefaultExecutor(thread_count);
+
+    for (uint32_t i = 0; i < runs_count; i++) {
+        std::string uuid;
+        ASSERT_TRUE(UUID::Generate(&uuid));
+        std::vector<std::future<void>> futures;
+        for (uint32_t thread_idx = 0; thread_idx < thread_count; thread_idx++) {
+            futures.push_back(Via(executor.get(), [this, &uuid]() -> void {
+                std::string dir_path = uuid;
                 ASSERT_OK(fs_->Mkdirs(dir_path));
                 ASSERT_OK_AND_ASSIGN(bool is_exist, fs_->Exists(dir_path));
                 ASSERT_TRUE(is_exist);

src/paimon/fs/local/local_file.cpp

@@ -158,17 +158,19 @@ Status LocalFile::Mkdir() const {
     size_t len = dir.size();
     if (dir[len - 1] == '/') {
         if (len == 1) {
-            return Status::Exist(fmt::format("directory '{}' already exist", dir));
+            return Status::OK();
         } else {
             dir.resize(len - 1);
         }
     }
     size_t pos = dir.rfind('/');
     if (pos == std::string::npos) {
         if (mkdir(dir.c_str(), 0755) < 0) {
-            int32_t cur_errno = errno;
-            return Status::IOError(
-                fmt::format("Mkdir path '{}' fail, ec: {}", dir, std::strerror(cur_errno)));
+            if (errno != EEXIST) {
+                int32_t cur_errno = errno;
+                return Status::IOError(
+                    fmt::format("Mkdir path '{}' fail, ec: {}", dir, std::strerror(cur_errno)));
+            }
         }
         return Status::OK();
     }

src/paimon/fs/local/local_file_test.cpp

@@ -178,9 +178,9 @@ TEST(LocalFileTest, TestOpenFile) {
     ASSERT_GE(modify_time, -1);
 
     LocalFile dir2 = LocalFile("/");
-    ASSERT_NOK_WITH_MSG(dir2.Mkdir(), "directory '/' already exist");
+    ASSERT_OK(dir2.Mkdir());
     LocalFile dir3 = LocalFile(test_root + "/");
-    ASSERT_NOK_WITH_MSG(dir3.Mkdir(), "already exist");
+    ASSERT_OK(dir3.Mkdir());
 }
 
 }  // namespace paimon::test