fix: coredump when sequence field is part of primary key #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Problem Description
In the
MergeFileSplitReadlogic for PK MOR tables:sequence.fieldis included in the primary key fields, the current implementation first splits the primary key (PK) and non-PK fields based on user read schema.sequence.fieldis added to the non-PK fields. However, this results in an incorrectarrow::Schemathat contains duplicate fields (e.g.,sequence.fieldappears in both PK and non-PK fields).arrow::Schema::GetFieldIndex()function does not handle duplicate fields gracefully and returns-1when duplicates are detected. This leads to a coredump during execution.Solution
To resolve this issue:
MergeFileSplitRead:sequence.fieldto the appropriate field set.This ensure no duplicate fields are introduced in the
arrow::Schema.Tests
WriteAndReadInteTest.TestPKWithSequenceFieldInPKField
WriteAndReadInteTest.TestPKWithSequenceFieldPartialInPKField