chore: Fix build_and_package.sh #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix CMAKE_OPTIONS argument passing: The original script incorrectly passed all CMake options as a single string instead of separate arguments
Fix build directory naming convention: Use lowercase for build type in directory names (build-release and build-debug instead of build-Release and build-Debug)
Switch default generator from Make to Ninja: Replace Make with Ninja as the default CMake generator to improve build performance
Add configurable parallel build jobs: Introduce -j/--jobs option to allow customization of parallel compilation threads
Tests
API and Format
Documentation