Skip to content

opt code #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bruceding wants to merge 1 commit into from
Closed

opt code #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion module/item_state_filter_tablestore_dao.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func (d *ItemStateFilterTablestoreDao) Filter(user *User, items []*Item, ctx *co
result, err := d.filterParam.EvaluateByDomain(userFeatures, properties)
if err != nil {
log.Error(fmt.Sprintf("requestId=%smodule=ItemStateFilterTablestoreDao\tevent=EvaluateFilterParam\terror=%v", ctx.RecommendId, err))
} else if err == nil && result {
} else if result {
fieldMap[id] = true
}
} else {
Expand Down
4 changes: 2 additions & 2 deletions module/vector_hologres_dao.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import (

"github.com/alibaba/pairec/v2/log"

"github.com/huandu/go-sqlbuilder"
"github.com/alibaba/pairec/v2/persist/holo"
"github.com/alibaba/pairec/v2/recconf"
"github.com/huandu/go-sqlbuilder"
)

type VectorHologresDao struct {
Expand Down Expand Up @@ -138,7 +138,7 @@ func FetchPartition(hologresName, table, field string) string {
}
var partition string

for rows.Next() {
if rows.Next() {
if err := rows.Scan(&partition); err != nil {
log.Error(fmt.Sprintf("module=VectorHologresDao\tevent=FetchPartition\terror=%v", err))
return ""
Expand Down