Skip to content

Resolve most of the issues with config.rs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 19, 2024
Merged

Resolve most of the issues with config.rs #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
46110f4
Remove need to specify `Option::<T>::None` etc in `config_data!`
cormacrelf Jan 18, 2024
fda1935
Last type annotation in config_data!
cormacrelf Jan 18, 2024
f77b64c
Reduce repetition in config_data! macro by splitting ConfigData into …
cormacrelf Jan 18, 2024
a364384
Sort the fields, so the diffs on the generated docs/schemas are smaller
cormacrelf Jan 18, 2024
8835d42
Add the default snippets back, tweak the serialize output until it's …
cormacrelf Jan 18, 2024
3ae48d1
serialize impl for true_or_always/false_or_never
cormacrelf Jan 18, 2024
86a8438
add serialize for the de_unit_v-s
cormacrelf Jan 18, 2024
48dd942
rename de_unit_v to unit_v
cormacrelf Jan 18, 2024
7b0c05d
Bring the diff down to zero using BTreeMap for snippets, @from_str:
cormacrelf Jan 18, 2024
c474ebb
use indexmap instead of BTreeMap for deterministic snippet output
cormacrelf Jan 18, 2024
172da25
rename `@from_str: ` to `@verbatim: `
cormacrelf Jan 18, 2024
568ee9a
Didn't mean for indexmap to be one of "these 3 deps"
cormacrelf Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion crates/rust-analyzer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@ triomphe.workspace = true
toml = "0.8.8"
nohash-hasher.workspace = true
always-assert = "0.1.2"
indexmap = { version = "2.0.0", features = ["serde"] }

# These 3 deps are not used by r-a directly, but we list them here to lock in their versions
# These 2 deps are not used by r-a directly, but we list them here to lock in their versions
# in our transitive deps to prevent them from pulling in windows-sys 0.45.0
mio = "=0.8.5"
parking_lot_core = "=0.9.6"
Expand Down
Loading