Skip to content

Commit 849a3f4

Browse files
committed
Unreviewed, 290246@main introduced a lot of Safer CPP failures on EWS
https://bugs.webkit.org/show_bug.cgi?id=287543 * Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::requestAttachmentIcon): (WebKit::WebPageProxy::sendToWebPage): Canonical link: https://commits.webkit.org/290257@main
1 parent 8df35ca commit 849a3f4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ UIProcess/ProvisionalFrameProxy.cpp
2020
UIProcess/SuspendedPageProxy.cpp
2121
UIProcess/UserMediaPermissionRequestManagerProxy.cpp
2222
UIProcess/WebContextMenuProxy.cpp
23+
UIProcess/WebPageProxy.cpp
2324
UIProcess/WebEditCommandProxy.cpp
2425
UIProcess/WebURLSchemeTask.cpp
2526
UIProcess/mac/WKImmediateActionController.mm

Source/WebKit/UIProcess/WebPageProxy.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14057,7 +14057,7 @@ void WebPageProxy::requestAttachmentIcon(IPC::Connection& connection, const Stri
1405714057
{
1405814058
MESSAGE_CHECK_BASE(protectedPreferences()->attachmentElementEnabled(), connection);
1405914059

14060-
auto updateAttachmentIcon = [&] {
14060+
auto updateAttachmentIcon = [&, protectedThis = Ref { *this }] {
1406114061
FloatSize size = requestedSize;
1406214062
std::optional<ShareableBitmap::Handle> handle;
1406314063

@@ -15573,7 +15573,7 @@ template<typename F>
1557315573
decltype(auto) WebPageProxy::sendToWebPage(std::optional<FrameIdentifier> frameID, F&& sendFunction)
1557415574
{
1557515575
if (RefPtr frame = WebFrameProxy::webFrame(frameID)) {
15576-
if (auto* remotePage = protectedBrowsingContextGroup()->remotePageInProcess(*this, frame->protectedProcess()))
15576+
if (RefPtr remotePage = protectedBrowsingContextGroup()->remotePageInProcess(*this, frame->protectedProcess()))
1557715577
return sendFunction(*remotePage);
1557815578
}
1557915579
return sendFunction(*this);

0 commit comments

Comments
 (0)