Enhancement of feature matching processing distribution amongs available chunks

[servantftransperfect]

• Cleanup loading and saving of pairs of indices (Output of ImageMatching)

• Removed the "stream" version as they were never used

• Cleanup exhaustive generation of pairs of indices (used if no imageMatching output)

• Removed the obligation that pair.first < pair.second in the loaded file. This enable to have both directions in the same file (which is required for "star" roma)

• Removed error if a pair contains twice the same value (To enable mirror matching)

• Distribution of pairs to compute among chunks is now way more efficient ! Previous solution was to use the reference views as the items to distribute; But this is obviously creating problems as the numbers of pairs with the same reference image is not uniform at all.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

src/aliceVision/matchingImageCollection/ImagePairListIO_test.cpp:34

• This test expectation no longer matches the current loadPairsFromFile() behavior: with the default useSymmetry=true, a line "2 0" will be normalized and loaded as pair (0,2), not (2,0). As written, loaded_Pairs will not be equal to pairSetGTsorted. Either update the expected set back to (0,2) or change loadPairsFromFile() semantics/defaults if directionality is intended to be preserved.

    PairSet pairSetGTsorted;
    pairSetGTsorted.insert(std::make_pair(0, 1));
    pairSetGTsorted.insert(std::make_pair(2, 0));
    pairSetGTsorted.insert(std::make_pair(1, 2));

    BOOST_CHECK(savePairsToFile("pairsT_IO.txt", pairSetGT));

    PairSet loaded_Pairs;
    BOOST_CHECK(loadPairsFromFile("pairsT_IO.txt", loaded_Pairs));
    BOOST_CHECK(std::equal(loaded_Pairs.begin(), loaded_Pairs.end(), pairSetGTsorted.begin()));

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.