Skip to content

imageProcessing: guard OpenCV-dependent filters behind ALICEVISION_HA… #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
servantftransperfect merged 3 commits into from
Mar 25, 2026
Merged

imageProcessing: guard OpenCV-dependent filters behind ALICEVISION_HA… #2090

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cabece
imageProcessing: guard OpenCV-dependent filters behind ALICEVISION_HA…
Mar 19, 2026
1450b4c
Apply suggestion from @fabiencastan
predat Mar 19, 2026
4d732b0
fix(imageProcessing): fix guard placement for bilateralFilter and nlm…
Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/software/utils/main_imageProcessing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,19 @@ void setupSteps(std::list<std::unique_ptr<ImageProcess>> & steps, const Processi
}
if (pParams.bilateralFilter.enabled)
{
#if ALICEVISION_IS_DEFINED(ALICEVISION_HAVE_OPENCV)
steps.push_back(std::make_unique<BilateralFilterProcess>(pParams.bilateralFilter.distance, pParams.bilateralFilter.sigmaColor, pParams.bilateralFilter.sigmaSpace));
#else
ALICEVISION_LOG_ERROR("OpenCV support is not enabled in this AliceVision build. Bilateral filter processing is unavailable and will be bypassed.");
#endif
}
if (pParams.claheFilter.enabled)
{
#if ALICEVISION_IS_DEFINED(ALICEVISION_HAVE_OPENCV)
steps.push_back(std::make_unique<ClaheFilterProcess>(pParams.claheFilter.tileGridSize, pParams.claheFilter.clipLimit));
#else
ALICEVISION_LOG_ERROR("OpenCV support is not enabled in this AliceVision build. Clahe filter processing is unavailable and will be bypassed.");
#endif
}
if (pParams.fillHoles)
{
Expand All @@ -539,9 +547,13 @@ void setupSteps(std::list<std::unique_ptr<ImageProcess>> & steps, const Processi
steps.push_back(std::make_unique<NoiseProcess>(ENoiseMethod_enumToString(pParams.noise.method), pParams.noise.A, pParams.noise.B, pParams.noise.mono));
}
if (pParams.nlmFilter.enabled)
#if ALICEVISION_IS_DEFINED(ALICEVISION_HAVE_OPENCV)
{
steps.push_back(std::make_unique<NlmFilterProcess>(pParams.nlmFilter.filterStrength, pParams.nlmFilter.filterStrengthColor, pParams.nlmFilter.templateWindowSize, pParams.nlmFilter.searchWindowSize));
}
#else
ALICEVISION_LOG_ERROR("OpenCV support is not enabled in this AliceVision build. Nlm filter processing is unavailable and will be bypassed.");
#endif
if (pParams.applyDcpMetadata || pParams.enableColorTempProcessing)
{
steps.push_back(std::make_unique<ColorTemperatureProcess>(pParams.applyDcpMetadata, pParams.useDCPColorMatrixOnly, pParams.enableColorTempProcessing, pParams.correlatedColorTemperature));
Expand Down
Loading