Open
Conversation
servantftransperfect
force-pushed
the
dev/imageGroup
branch
from
26dd2b9 to
a93f45d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
servantftransperfect
force-pushed
the
dev/imageGroup
branch
from
a93f45d to
f272d3c
Compare
servantftransperfect
force-pushed
the
dev/imageGroup
branch
from
f272d3c to
f783104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an imageGroup concept in the sfmData.
This imageGroup may be ImageSet or ImageSequence.
The views are grouped by imageGroup. One view will be linked to only one image group.
Each view will contains its image group id.
For the moment, each view is grouped with the other views inserted in the same cameraInit/listImages.
Parameter Additions:
isSequenceto theCameraInitnode inmeshroom/aliceVision/CameraInit.pyto indicate if input images are part of a temporally coherent sequence.isSequenceto theListImagesnode inmeshroom/aliceVision/ListImages.pywith similar semantics.