Skip to content

Add sfmDataIntersection CLI tool and Meshroom node#2100

Open
Copilot wants to merge 2 commits intodevelopfrom
copilot/add-sfmdata-intersection-command
Open

Add sfmDataIntersection CLI tool and Meshroom node#2100
Copilot wants to merge 2 commits intodevelopfrom
copilot/add-sfmdata-intersection-command

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

  • Update src/software/utils/main_sfmDataIntersection.cpp:
    • Replace input1/input2 params with input (content source), inputA, inputB (view-list sources)
    • Load main input as the output base; load inputA/inputB with VIEWS only to extract view ID sets
    • Filter landmarks from main input: keep only those observed by ≥1 view from each set
    • Bump VERSION_MAJOR to 2, VERSION_MINOR to 0
  • Update meshroom/aliceVision/SfMDataIntersection.py:
    • Replace input1/input2 with input, inputA, inputB
    • Update size to DynamicNodeSize("input"), documentation, and __version__ to "2.0"

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…ection.py Meshroom node

Agent-Logs-Url: https://github.com/alicevision/AliceVision/sessions/ea7988c2-09f6-4824-b7c9-2df9d644ad20

Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot AI requested a review from fabiencastan March 27, 2026 20:17
@fabiencastan fabiencastan marked this pull request as ready for review March 30, 2026 09:57
@fabiencastan fabiencastan added this to the 3.4.0 milestone Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants