Fixes JsonProperty with no PropertyName value and adds tests (#103)

Author: kylednoland

src/Aliencube.AzureFunctions.Extensions.OpenApi.Core/Extensions/PropertyInfoExtensions.cs

@@ -37,7 +37,7 @@ public static string GetJsonPropertyName(this PropertyInfo element, NamingStrate
 
             if (element.HasJsonPropertyAttribute())
             {
-                var name = element.GetCustomAttribute<JsonPropertyAttribute>().PropertyName;
+                var name = element.GetCustomAttribute<JsonPropertyAttribute>().PropertyName ?? namingStrategy.GetPropertyName(element.Name, hasSpecifiedName: false);
 
                 return name;
 

test/Aliencube.AzureFunctions.Extensions.OpenApi.Core.Tests.Fakes/FakeModel.cs

@@ -19,6 +19,12 @@ public class FakeModel
         [JsonProperty("anotherFakeProperty", Required = Required.Always)]
         public string FakeProperty2 { get; set; }
 
+        [JsonProperty(Required = Required.Default)]
+        public string FakePropertyNoPropertyValue { get; set; }
+
+        [JsonProperty]
+        public string FakePropertyNoAnnotation { get; set; }
+
         /// <summary>
         /// Gets or sets the nullable int value.
         /// </summary>

test/Aliencube.AzureFunctions.Extensions.OpenApi.Core.Tests/Extensions/PropertyInfoExtensionsTests.cs

@@ -40,5 +40,59 @@ public void Given_Property_When_GetJsonPropertyName_Invoked_Then_It_Should_Retur
 
             result.Should().Be(jsonPropertyName);
         }
+
+        [TestMethod]
+        public void Given_Property_When_GetJsonPropertyName_IsEmpty_Then_It_Should_Return_ElementName()
+        {
+            var name = "FakePropertyNoPropertyValue";
+            var property = typeof(FakeModel).GetProperty(name, BindingFlags.Public | BindingFlags.Instance);
+            var namingStrategy = new DefaultNamingStrategy();
+
+            var result = PropertyInfoExtensions.GetJsonPropertyName(property, namingStrategy);
+
+            result.Should().NotBeNullOrEmpty();
+            result.Should().Be(name);
+        }
+
+        [TestMethod]
+        public void Given_Property_When_DefaultJsonProperyAnnotation_Invoked_Then_It_Should_Return_ElementName()
+        {
+            var name = "FakePropertyNoAnnotation";
+            var property = typeof(FakeModel).GetProperty(name, BindingFlags.Public | BindingFlags.Instance);
+            var namingStrategy = new DefaultNamingStrategy();
+
+            var result = PropertyInfoExtensions.GetJsonPropertyName(property, namingStrategy);
+
+            result.Should().NotBeNullOrEmpty();
+            result.Should().Be(name);
+        }
+
+        [TestMethod]
+        public void Given_Property_When_GetJsonPropertyName_IsEmpty_WithCamelCaseNaming_Then_It_Should_Return_ElementName()
+        {
+            var name = "FakePropertyNoPropertyValue";
+            var camelCaseName = "fakePropertyNoPropertyValue";
+            var property = typeof(FakeModel).GetProperty(name, BindingFlags.Public | BindingFlags.Instance);
+            var namingStrategy = new CamelCaseNamingStrategy();
+
+            var result = PropertyInfoExtensions.GetJsonPropertyName(property, namingStrategy);
+
+            result.Should().NotBeNullOrEmpty();
+            result.Should().Be(camelCaseName);
+        }
+
+        [TestMethod]
+        public void Given_Property_When_DefaultJsonProperyAnnotation_Invoked_WithCamelCaseNaming_Then_It_Should_Return_ElementName()
+        {
+            var name = "FakePropertyNoAnnotation";
+            var camelCaseName = "fakePropertyNoAnnotation";
+            var property = typeof(FakeModel).GetProperty(name, BindingFlags.Public | BindingFlags.Instance);
+            var namingStrategy = new CamelCaseNamingStrategy();
+
+            var result = PropertyInfoExtensions.GetJsonPropertyName(property, namingStrategy);
+
+            result.Should().NotBeNullOrEmpty();
+            result.Should().Be(camelCaseName);
+        }
     }
 }