Add JitMode enum with auto/on/off support#2
Open
alies-dev wants to merge 1 commit intodisable-jit-by-defaultfrom
Open
Add JitMode enum with auto/on/off support#2alies-dev wants to merge 1 commit intodisable-jit-by-defaultfrom
alies-dev wants to merge 1 commit intodisable-jit-by-defaultfrom
Conversation
Introduce a JitMode enum to replace the boolean forceJit flag, providing three modes: - auto (default): enable JIT when available, continue without it - on: require JIT, exit if unavailable (former --force-jit behavior) - off: never enable JIT Backward compatible: true maps to on, false maps to off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #1 to replace the boolean
forceJitwith a three-modeJitModeenum:auto(default) — enable JIT when available, continue gracefully without iton— require JIT, exit if unavailable (equivalent to--force-jit)off— never enable JITBackward compatibility
forceJit="true"maps toon,forceJit="false"maps tooff. Existing configs continue to work.The
autodefault preserves the current behavior of attempting JIT without hard-failing, while giving users explicit control when needed (e.g.offto avoid JIT segfaults during taint analysis).Changes
Psalm\JitModebacked enum withfromConfig()for parsingConfig::$force_jit(bool) →Config::$jit_mode(JitMode)PsalmRestarter::$enableJit(bool) →PsalmRestarter::$jitMode(JitMode)auto, informational inoff, error inon