boards: alif: alif_b1_dk: Add common DTSI files for both SoC series#285
boards: alif: alif_b1_dk: Add common DTSI files for both SoC series#285Prabhakar-Alifsemi wants to merge 1 commit intoalifsemi:mainfrom
Conversation
The PR points to alifsemi/zephyr_alif#285 Signed-off-by: Prabhakar Kumar <prabhakar.kumar@alifsemi.com>
Tanay-AlifSemi
left a comment
There was a problem hiding this comment.
as many nodes getting duplicated, can we have a common boards/alif/alif_b1_dk/alif_b1_dk_common_rtss_he.dtsi file for all the b1 SoCs
?
|
@Prabhakar-Alifsemi Please rebase. |
There was a problem hiding this comment.
Pull request overview
This PR consolidates duplicate device tree configuration code by extracting common definitions into reusable DTSI files. The refactoring creates two shared include files for the two SoC series variants (ab1c1f4m51820xx0 and ab1c1f1m41820xx0), removing duplication across four board-specific DTS files.
- Created two new common DTSI files containing shared device tree definitions
- Updated four board-specific DTS files to include the appropriate common DTSI file
- Removed duplicate configuration blocks from the board-specific DTS files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| alif_b1_dk_ab1c1f4m51820xx0_rtss_he.dtsi | New common DTSI file for ab1c1f4m51820xx0 SoC series with UART, DMA, GPIO, and HCI configurations |
| alif_b1_dk_ab1c1f4m51820ph0_rtss_he.dts | Updated to include common DTSI, removing 70+ lines of duplicate configuration |
| alif_b1_dk_ab1c1f4m51820hh0_rtss_he.dts | Updated to include common DTSI, removing 70+ lines of duplicate configuration |
| alif_b1_dk_ab1c1f1m41820xx0_rtss_he.dtsi | New common DTSI file for ab1c1f1m41820xx0 SoC series with basic UART and GPIO configurations |
| alif_b1_dk_ab1c1f1m41820ph0_rtss_he.dts | Updated to include common DTSI, removing duplicate configuration (note: previously had additional PWM configuration) |
| alif_b1_dk_ab1c1f1m41820hh0_rtss_he.dts | Updated to include common DTSI, removing duplicate configuration (note: previously had additional PWM configuration) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
63f6b8c to
4fef5cf
Compare
boards/alif/alif_b1_dk/alif_b1_dk_ab1c1f4m51820xx0_rtss_he.dtsi
Outdated
Show resolved
Hide resolved
4fef5cf to
74068c9
Compare
The PR points to alifsemi/zephyr_alif#285 Signed-off-by: Prabhakar Kumar <prabhakar.kumar@alifsemi.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
74068c9 to
1ddb2d6
Compare
Add the common DTSI includes for the two supported SoC series: 1. alif_b1_dk_ab1c1f1m41820xx0_rtss_he.dtsi 2. alif_b1_dk_ab1c1f4m51820xx0_rtss_he.dtsi These files contain shared definitions used across both variants. Signed-off-by: Prabhakar Kumar <prabhakar.kumar@alifsemi.com>
1ddb2d6 to
96aea94
Compare
|
@Prabhakar-Alifsemi Please resolve the conflicts |
Add the common DTSI includes for the two supported SoC series:
These files contain shared definitions used across both variants.