drivers: gpio: designware: add alif pinctrl support#338
Open
timKnodel wants to merge 1 commit intoalifsemi:mainfrom
Open
drivers: gpio: designware: add alif pinctrl support#338timKnodel wants to merge 1 commit intoalifsemi:mainfrom
timKnodel wants to merge 1 commit intoalifsemi:mainfrom
Conversation
|
Hi @RupeshKumar-AlifSemi, can you please review this improvement? |
There was a problem hiding this comment.
Pull request overview
This PR enables dynamic GPIO pull-up/pull-down control in the DesignWare GPIO driver by integrating Alif pinctrl support. The changes refactor pinctrl definitions to be shared between drivers.
Changes:
- Moved pinctrl macros and definitions from
pinctrl_alif.ctopinctrl_soc.hheader for reusability - Added pull-up/pull-down configuration support in the DesignWare GPIO driver when
CONFIG_PINCTRL_ALIFis enabled - Introduced DSC (Driver State Control) constants for different pull modes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| soc/alif/common/pinctrl_soc.h | Added LPGPIO documentation, DSC constants, and relocated shared pinctrl macros from driver |
| drivers/pinctrl/pinctrl_alif.c | Removed duplicate definitions now in header, added reference to pinctrl_soc.h |
| drivers/gpio/gpio_dw.c | Added conditional pinctrl integration for dynamic pull-up/pull-down configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
silesh-alifsemi
requested changes
Jan 27, 2026
timKnodel
force-pushed
the
f/add-gpio-pinmux
branch
from
b2e9d0e to
bb95a19
Compare
Contributor
|
CI fails because of:
|
To dynamically control gpio pull-up/pull-down through the gpio API the designware driver needs to call the alif pinctrl if CONFIG_PINCTRL_ALIF is enabled. Signed-off-by: Tim Knodel <tbk@google.com>
timKnodel
force-pushed
the
f/add-gpio-pinmux
branch
from
bb95a19 to
a7a5053
Compare
Author
|
Formatting issues fixed. |
petrih-alifsemi
approved these changes
Feb 6, 2026
AnttiKauppila-AlifSemi
approved these changes
Feb 6, 2026
silesh-alifsemi
requested changes
Feb 9, 2026
| * 0x1000 away from the base address in port order. | ||
| */ | ||
| #define GPIO_PORT_FROM_ADDRESS(x) \ | ||
| (x < GPIO_PORT_BASE_ADDRESS ? 15U : (x - GPIO_PORT_BASE_ADDRESS) / 0x1000) |
Contributor
There was a problem hiding this comment.
Would not this fail for GPIO16 (0x4300_A000) and GPIO 17 (0x4300_B000) ?
| } | ||
|
|
||
| #if CONFIG_PINCTRL_ALIF | ||
| uint32_t port_pin_value = (GPIO_PORT_FROM_ADDRESS(context->base_addr) << 3U) | (pin & 0x7U); |
Contributor
There was a problem hiding this comment.
Suggested change
| uint32_t port_pin_value = (GPIO_PORT_FROM_ADDRESS(context->base_addr) << 3U) | (pin & 0x7U); | |
| uint32_t port_pin_value = ((GPIO_PORT_FROM_ADDRESS(context->base_addr) << 3U) | (pin & 0x7U)) << PIN_FUNC_SHIFT; |
| uint32_t *pinctrl_addr; | ||
|
|
||
| if (LPGPIO_PINCTRL_BASE && (GET_PINMUX_PORT(port_pin_value) == LPGPIO_PORT)) { | ||
| pinctrl_addr = (uint32_t *)LPGPIO_PINMUX_ADDR(port_pin_value); |
Contributor
There was a problem hiding this comment.
With the above suggested change (to shift port_pin_value by PIN_FUNC_SHIFT), we might break this calculation of pinctrl_addr. So this will need to be handled separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To dynamically control gpio pull-up/pull-down through the gpio API the designware driver needs to call the Alif pinctrl if CONFIG_PINCTRL_ALIF is enabled. This moves some of the helper functions from the c file to the header file to simplify the driver.