hal_ethos_u: Update to upstream commit for ethosu_config_select#431
Conversation
Taking upstream commit db2caeb33975acbcd4db1c517120c0eada1798ac to get ethosu_config_select platform hook changes. Add ethosu_config_select platform hook Allow config and hence port selection to be done at run-time based on region address, avoiding need to recompile C code for linker map changes, and permitting an application to have one model in SRAM and another in external memory. Change-Id: I425ee1ad2598b65a3c891261a7eff00e9565bdbe Signed-off-by: Kevin Bracey <kevin.bracey@alifsemi.com> Signed-off-by: Jonny Svärd <jonny.svaerd@arm.com> Signed-off-by: Srinivasa Rao Ragolu <srinivasa@alifsemi.com>
SrinivasRagolu-AlifSemi
requested review from
a team,
JuhoEskeli-AlifSemi,
RupeshKumar-AlifSemi,
VeijoPesonen and
petrih-alifsemi
|
Is there reason not taking the latest commit version? |
I see there's caching changes which would then need to be considered. So is the idea to just make a safe jump forward which should not cause additional rework? |
Juho, when I go through the other top commits its more of documentation and cache weak function changes. This commit is stable per Kevin Bracy, who tested it on the ML toolkit side as well. |
Actually, those cache functions are weak functions and are overridden by our own implementation, which works cache management perfectly fine. Rather than a safe jump, its stable commit jump. |
The PR refers to alifsemi/zephyr_alif/pull/431 Signed-off-by: Srinivasa Rao Ragolu <srinivasa@alifsemi.com>
|
In ML toolkit we seem to be at commit 60b4fbf76af8bff11c316588e77b7d626ab65e75 (HEAD, tag: 25.08-rc2, tag: 25.08-rc1, tag: 25.08, tag: 25.05-rc2, tag: 25.05, origin/main, origin/HEAD, main) |
db2caeb33975acbcd4db1c517120c0eada1798ac is required and suggested Kevin's commit. Do you suggest me to bump to latest commit? |
|
I discussed this with @kjbracey and we'll do as you originaly proposed. Cache changes can wait. |
Thanks for the confirmation. |
|
Please check CI check patch error |
3 participants
Taking upstream commit db2caeb33975acbcd4db1c517120c0eada1798ac to get ethosu_config_select platform hook changes.
Add ethosu_config_select platform hook
Allow config and hence port selection to be done at run-time based on region address, avoiding need to recompile C code for linker map changes, and permitting an application to have one model in SRAM and another in external memory.
Change-Id: I425ee1ad2598b65a3c891261a7eff00e9565bdbe