drivers: i2c: Correct i2c_dw target implementation#438
Open
Shreehari-AlifSemi wants to merge 1 commit intoalifsemi:mainfrom
Conversation
The I2C target implementation for i2c_dw does not follow the
zephyr target specification. The following three issues are corrected:
1) The read_requested CB is called on every byte of the transaction
- it must be called only on the first byte of the transaction
2) The read_processed CB is called on every byte of the transaction
- it must be called only on bytes following the first byte
3) Bytes returned in the data ptr param of read_processed are not
sent to the controller
-These bytes must be sent to the controller
Signed-off-by: James Growden <jgrowden@tenstorrent.com>
Signed-off-by: Shreehari HK <shreehari.hk@alifsemi.com>
Shreehari-AlifSemi
requested review from
Prabhakar-Alifsemi,
RupeshKumar-AlifSemi,
silesh-alifsemi and
sudhir-alifsemi
This was referenced Mar 25, 2026
silesh-alifsemi
requested changes
Mar 31, 2026
Contributor
silesh-alifsemi
left a comment
silesh-alifsemi
left a comment
There was a problem hiding this comment.
As this is an upstream patch, please use git-cherry-pick so that the details are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The I2C target implementation for i2c_dw does not follow the zephyr target specification. The following three issues are corrected:
-These bytes must be sent to the controller