Skip to content

Conversation

@aaronmedina-dev
Copy link
Contributor

@aaronmedina-dev aaronmedina-dev commented Mar 23, 2025


Description of the proposed changes

  • Update Aligent's Header Change Detection to accommodate BigCommerce checkout behavior
  • Added props to have an ability to add custom HTTP statuses.
  • Joined the URL Array to a single string before saving.

Screenshots (if applicable)
Before the change
image

After the Change
Test with added 406 status
image
Test without the 406
image

Other solutions considered (if any)

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Aaron Medina added 2 commits March 21, 2025 15:45
… SerializationException

Added parameter to accept custom http status
Copy link
Member

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a question and the Aikido recommendation needs review :)

@aaronmedina-dev
Copy link
Contributor Author

Looks good! Just a question and the Aikido recommendation needs review :)

I think for our use case, this is not applicable? Our URLs are passed as props to the construct at deploy time and not at runtime, so there's no user input that would allow SSRF exploitation (?).
What do you think @TheOrangePuff ?

@aaronmedina-dev aaronmedina-dev merged commit 49a572a into main Mar 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants