Skip to content

Removed set-cookie header, updated README #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finnholland merged 1 commit into from
May 1, 2025
Merged

Removed set-cookie header, updated README #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/geoip-redirect/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ interface RedirectFunctionOptions {
| Property | Definition |
| -------- | ---------- |
| `supportedRegions` | A record with domain codes as a key (regex) and a domain to redirect to as a value |
| `defaultRegionCode` | The default region code(s) as regex. These are the regions supported by `defaultDomain`. When multiple codes are used the default will be the first code the default site eg. `AU,NZ` will treat `AU` as the default |
| `defaultRegionCode` | The default region code(s) as regex. These are the regions supported by `defaultDomain`. When multiple codes are used the default will be the first code the default site eg. `["AU","NZ"]` will treat `AU` as the default |
| `defaultDomain` | The website's main domain. This will act as a fallback for any unsupported regions |
| `enablePathRedirect` | Will toggle adding a path suffix for a region such as `.com/au` or whether it should just be `.com` |

Expand All @@ -34,20 +34,20 @@ First off your website has a basic domain let's say `www.aligent.com.au` and you

```
redirectBehaviourOptions: {
defaultDomain: "www.iamawesome.com/au",
defaultRegionCode: "AU,NZ",
defaultDomain: "www.aligent.com/au",
defaultRegionCode: ["AU","NZ"],
}
```

Any region codes that are regexed to be `XX,YY` (note the comma `,`) will automatically add the matching region as a path suffix to the url.
Any region codes that are in the array like: `["XX","YY"]` will automatically add the matching region as a path suffix to the url as lowercase.

However in order to redirect to a website that is different from the base domain such as `www.aligent.co.nz` you can "hardcode" a domain for a region to use by using the `supportedRegions` value.

```
redirectBehaviourOptions: {
defaultDomain: "www.example.com",
defaultDomain: "www.aligent.com",
defaultRegionCode: "AU,US",
supportedRegions: { "NZ": "www.example.co.nz" }
supportedRegions: { "NZ": "www.aligent.co.nz" }
}
```

Expand Down
1 change: 0 additions & 1 deletion packages/header-change-detection/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ By default, the following headers are monitored:
- Referrer-Policy
- Permission-Policy
- Cache-Control
- Set-Cookie

## Usage

Expand Down
1 change: 0 additions & 1 deletion packages/header-change-detection/lib/header-change-detection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ const defaultHeaders = [
"referrer-policy",
"permission-policy",
"cache-control",
"set-cookie",
];

export class HeaderChangeDetection extends Construct {
Expand Down