Skip to content

Conversation

@TheOrangePuff
Copy link
Member

Summary

This PR standardizes configuration across the monorepo to improve maintainability and developer experience.

Changes

1. ESLint Configuration Consolidation

  • Removed 13 redundant package-level .eslintrc.json files
  • Updated root ESLint config to handle all packages directly
  • Changed ignore patterns from blocking everything to targeting specific build artifacts

2. Package.json Scripts Standardization

  • Added consistent test and lint scripts to all 13 packages
  • Used format: "test": "npx nx test {project-name}" and "lint": "npx nx lint {project-name}"
  • Preserved existing build scripts (including Lambda handler npm ci steps)
  • Removed inconsistent scripts (direct Jest calls, unused watch scripts)

3. Repository URL Standardization

  • Updated 7 packages with outdated repository URLs to point to monorepo
  • Changed from individual package repositories to unified: git+https://github.com/aligent/aws-cdk-constructs.git
  • Standardized homepage URLs to use package-specific tree paths
  • Added missing bugs URLs for consistency

Benefits

Reduced Maintenance: Single ESLint config instead of 14
Consistency: Uniform scripts and configuration across all packages
Developer Experience: Scripts work from both root and package directories
Documentation: All packages correctly reference the monorepo

Testing

  • ✅ All packages build successfully
  • ✅ All packages lint successfully
  • ✅ All test commands work correctly
  • ✅ No changes to actual build/test/lint behavior

Breaking Changes

None - all functionality operates exactly as before.

🤖 Generated with Claude Code

TheOrangePuff and others added 2 commits June 24, 2025 14:36
- Remove 13 redundant package-level .eslintrc.json files
- Update root ESLint config to handle all packages directly
- Change ignorePatterns from "**/*" to specific build artifacts
- All packages had identical configs with no package-specific rules
- Reduces maintenance overhead and ensures consistency

Benefits:
- Single ESLint config to maintain
- Guaranteed uniform linting across packages
- Simplified setup for new packages
- Faster ESLint resolution

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Package Scripts Standardization:
- Add consistent test and lint scripts to all 13 packages
- Use 'npx nx test {project-name}' and 'npx nx lint {project-name}' format
- Preserve existing build scripts (including Lambda handler npm ci steps)
- Remove inconsistent scripts (direct Jest calls, unused watch scripts)

Repository URL Standardization:
- Update 7 packages with outdated repository URLs to point to monorepo
- Change from individual package repositories to unified monorepo URL
- Standardize homepage URLs to use package-specific tree paths
- Add missing bugs URLs for consistency

Benefits:
- Consistent developer experience across all packages
- Scripts work from both root and package directories
- All packages now correctly reference the monorepo
- Unified issue tracking and documentation links

All builds, tests, and linting verified to work exactly as before.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@TheOrangePuff TheOrangePuff requested a review from a team as a code owner June 24, 2025 06:06
@TheOrangePuff TheOrangePuff marked this pull request as draft June 24, 2025 06:06
@TheOrangePuff TheOrangePuff marked this pull request as ready for review June 24, 2025 06:25
Copy link
Contributor

@porhkz porhkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheOrangePuff TheOrangePuff merged commit 5e5d5fe into main Jul 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants