Add gentoo by Lucretia · Pull Request #2006 · alire-project/alire

Lucretia · 2025-09-13T16:09:48Z

Adds in support for Gentoo's Portage.

PR creation checklist

A test is included, if required by the changes.
doc/user-changes.md has been updated, if there are user-visible changes.
doc/catalog-format-spec.md has been updated, if applicable.
BREAKING.md has been updated for major changes in alr, minor/major in catalog format.

* dev: check templates are up to date * Touch template * Better feedback * Restore touched template

* dev: instructions for copilot reviews * Add info about testing

…2000) * Minimal spec for future property * Implementation & Test * Do not leak hidden property

…ject#2003) * attempt fixing workflow on aarch64 linux * dev: force macOS 14 macos-latest runner is now macOS 15 which breaks things, yet to diagnose... * fix: force macOS 14 in `ci-toolchain.yml` * dev: remove custom aarch case from `ci-release.yml` * Revert "dev: remove custom aarch case from `ci-release.yml`" This reverts commit 069997e. --------- Co-authored-by: Alejandro R Mosteo <amosteo@unizar.es>

…ject#2005) * Add test * Fix incidental output breaking structured output * Add note to `--format`'s description * Fix typo in test comment Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Lucretia · 2025-09-13T16:56:01Z

Absolutely no idea why this fails on gcc 10. I don't have it installed here as it's now masked and cannot be installed easily. This is the line:

      return (if Line (Line'First .. Line'First + Indicator'Length) = Indicator
              then True else False);

Would changing it to:

return Line (Line'First .. Line'First + Indicator'Length) = Indicator;

Instead work?

Lucretia · 2025-09-13T17:34:52Z

Any ideas?

Seb-MCaw · 2025-09-14T12:03:00Z

I believe the issue is that Ada ranges are inclusive (not half-open intervals like many other languages), so you probably want something like

return Line (Line'First .. Line'First + Indicator'Length - 1) = Indicator;

I'm a little surprised that only GCC 10 catches this, though, so perhaps I'm missing something.

I'm not familiar with the eix command, but it would probably also be a good idea to check that Line'Length >= Indicator'Length to avoid a Constraint_Error.

That said, it would likely be easier to just use the Has_Prefix function already provided by AAA.Strings.

Check to make sure we have a line to check before checking the line.

* feat: minimal vetting of GH PATs * Old check when forcing

github-actions · 2025-11-27T01:46:39Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

Lucretia · 2025-11-27T08:20:07Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

Nothing I can do.

mosteo · 2025-11-27T10:38:08Z

Nothing I can do.

You can go over the review comments and fix those, that will remove the Stale status (and make the PR ready to merge :-))

Lucretia · 2025-11-27T15:01:15Z

Nothing I can do.

You can go over the review comments and fix those, that will remove the Stale status (and make the PR ready to merge :-))

I've no idea what you're talking about here. I can't review it, it's not my project.

mosteo · 2025-10-01T20:19:36Z

src/alire/alire-origins-deployers-system-portage.ads

+   function Install (This : Deployer) return Outcome;
+
+   overriding
+   function Executable_Name (This : Deployer) return String is ("apt");


Is this apt correct?

mosteo · 2025-10-01T20:21:02Z

src/alire/alire-origins-deployers-system-portage.adb

+      Indicator : constant String := "[I]";
+      Line      : constant String := AAA.Strings.First_Element (Output);
+   begin
+      Trace.Info ("Already_Installed: " & This.Base.Package_Name);


Logging at info level in a deployer will be noisy/confusing, I suggest downgrading at least to detail.

src/alire/alire-origins-deployers-system-portage.adb

mosteo · 2025-10-01T20:23:22Z

src/alire/alire-origins-deployers-system-portage.adb

+         if Tmp (C) = L1.Low_Line then
+            Tmp (C) := L1.Hyphen;
+
+            Trace.Info ("To_Semantic_Version: " & Tmp);


This looks like debug output

mosteo · 2025-10-01T20:23:39Z

src/alire/alire-origins-deployers-system-portage.adb

+         end if;
+      end loop;
+
+      Trace.Info ("To_Semantic_Version: " & Tmp);


This looks like debug output

mosteo · 2025-11-27T15:50:58Z

I've no idea what you're talking about here. I can't review it, it's not my project.

I did the review, my fault, I had left in draft.

Lucretia · 2025-11-28T12:04:44Z

No idea why this is failing. I don't know if it's me or not.

Seb-MCaw · 2025-12-01T18:05:28Z

No idea why this is failing. I don't know if it's me or not.

As identified in this CI check, 60705e7 reverted the deps/den submodule from bab6ef5 to 7732f92; presumably something got confused after the merge from master?

Lucretia · 2025-12-01T20:19:19Z

No idea why this is failing. I don't know if it's me or not.

As identified in this CI check, 60705e7 reverted the deps/den submodule from bab6ef5 to 7732f92; presumably something got confused after the merge from master?

I think I merged an update rather than rebased.

Seb-MCaw · 2025-12-03T10:50:05Z

I think I merged an update rather than rebased.

If this was addressed to me, I'm afraid I don't entirely understand what you mean. That 8dd254d was a merge commit was never in dispute.

Apologies if my previous comment didn't make it clear, but the provenance of the change is not important. All I was really trying to say is that, as far as I can tell, the CI is failing because deps/den points to 7732f92, and it should point to bab6ef5.

Lucretia · 2025-12-04T21:19:01Z

I think I merged an update rather than rebased.

If this was addressed to me, I'm afraid I don't entirely understand what you mean. That 8dd254d was a merge commit was never in dispute.

Apologies if my previous comment didn't make it clear, but the provenance of the change is not important. All I was really trying to say is that, as far as I can tell, the CI is failing because deps/den points to 7732f92, and it should point to bab6ef5.

Ok, I've no clue about any of that.

mosteo · 2025-12-05T09:21:59Z

I'll fix that

src/alire/alire-origins-deployers-system-portage.adb

mosteo · 2025-12-05T10:20:20Z

@Lucretia would you be willing to prepare a Docker file so we can test crates on gentoo? Akin to the ones we have in https://github.com/alire-project/dockerfiles

Lucretia · 2025-12-05T11:08:59Z

I don't know anything about docker.

You can run gentoo within a chroot if gh doesn't have a gentoo runner.

thesamesam · 2025-12-05T11:14:45Z

@mosteo I can handle that. We welcome upstreams being keen to test on Gentoo.

mosteo · 2025-12-05T11:17:08Z

Thanks @Lucretia

mosteo · 2025-12-05T11:18:30Z

@mosteo I can handle that. We welcome upstreams being keen to test on Gentoo.

That's great, Sam.

Lucretia · 2025-12-05T11:22:09Z

There is this: https://github.com/gentoo/gentoo-docker-images

Oh that's Gentoo Sam, so he'll already know about that.

Lucretia and others added 12 commits July 31, 2025 20:32

Add Gentoo and Portage into the platforms and package managers.

6acdf9b

Add a new package to support portage on Gentoo.

00d0492

Hook in Gentoo/Portage into the Deployers

24357e3

dev: check templates are up to date (alire-project#1995)

ba4154d

* dev: check templates are up to date * Touch template * Better feedback * Restore touched template

dev: guidelines for automatic Copilot reviews (alire-project#1998)

9f400ff

* dev: instructions for copilot reviews * Add info about testing

fix: pass GH token in Docker tests too (alire-project#1999)

949aa16

dev: placeholder for ignoring known future properties (alire-project#…

4ae0f4e

…2000) * Minimal spec for future property * Implementation & Test * Do not leak hidden property

fix: typos in catalog-format-spec.md (alire-project#2002)

4c31954

Add documentation for Gentoo.

ff77496

Merge branch 'master' into add-gentoo

89697c6

Simplify the expression.

7345f7a

Lucretia and others added 3 commits September 27, 2025 20:16

Fix indexing error.

bdea4b0

Check to make sure we have a line to check before checking the line.

feat: validation of GH PATs (alire-project#1994)

c0bf7b9

* feat: minimal vetting of GH PATs * Old check when forcing

Merge branch 'master' into add-gentoo

6b3e60a

Lucretia mentioned this pull request Nov 13, 2025

Add gentoo gmp alire-project/alire-index#1668

Merged

github-actions bot added the Stale label Nov 27, 2025

mosteo requested changes Nov 27, 2025

View reviewed changes

github-actions bot removed the Stale label Nov 28, 2025

Lucretia added 2 commits November 28, 2025 09:30

Merge remote-tracking branch 'upstream/master' into add-gentoo

8dd254d

Correct the package manager's name to emerge.

60705e7

Lucretia added 3 commits November 28, 2025 09:35

Change the log level to Detail.

395b759

Change Info -> Debug.

7a54348

Add the comment box.

25737fb

mosteo added 2 commits December 5, 2025 10:24

Bump den dependency

321447e

Downgrade level of some logs

c59d0ae

mosteo approved these changes Dec 5, 2025

View reviewed changes

src/alire/alire-origins-deployers-system-portage.adb Outdated Show resolved Hide resolved

mosteo merged commit 87c9375 into alire-project:master Dec 5, 2025
36 checks passed

thesamesam mentioned this pull request Dec 5, 2025

Add Gentoo image alire-project/dockerfiles#4

Merged

Uh oh!

Conversation

Lucretia commented Sep 13, 2025

PR creation checklist

Uh oh!

Lucretia commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lucretia commented Sep 13, 2025

Uh oh!

Seb-MCaw commented Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

Lucretia commented Nov 27, 2025

Uh oh!

mosteo commented Nov 27, 2025

Uh oh!

Lucretia commented Nov 27, 2025

Uh oh!

mosteo Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

mosteo Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mosteo Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

mosteo Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

mosteo commented Nov 27, 2025

Uh oh!

Lucretia commented Nov 28, 2025

Uh oh!

Seb-MCaw commented Dec 1, 2025

Uh oh!

Lucretia commented Dec 1, 2025

Uh oh!

Seb-MCaw commented Dec 3, 2025

Uh oh!

Lucretia commented Dec 4, 2025

Uh oh!

mosteo commented Dec 5, 2025

Uh oh!

Uh oh!

mosteo commented Dec 5, 2025

Uh oh!

Lucretia commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thesamesam commented Dec 5, 2025

Uh oh!

Uh oh!

mosteo commented Dec 5, 2025

Uh oh!

mosteo commented Dec 5, 2025

Uh oh!

Lucretia commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Lucretia commented Sep 13, 2025 •

edited

Loading

Seb-MCaw commented Sep 14, 2025 •

edited

Loading

Lucretia commented Dec 5, 2025 •

edited

Loading

Lucretia commented Dec 5, 2025 •

edited

Loading