fix: don't choke on other OS path separators#2010
Merged
mosteo merged 4 commits intoalire-project:masterfrom Oct 3, 2025
Merged
fix: don't choke on other OS path separators#2010mosteo merged 4 commits intoalire-project:masterfrom
mosteo merged 4 commits intoalire-project:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #1984 by handling path separators from different operating systems correctly. The fix prevents the tool from failing when encountering paths with non-native path separators (e.g., backslashes on Unix or forward slashes on Windows).
Key changes:
- Updates path handling logic to scrub non-native separators before processing
- Adds comprehensive test coverage for cross-platform path separator scenarios
- Updates the
dendependency to version 0.2 which includes the path scrubbing functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testsuite/tests/misc/other-slash-in-path/test.yaml | Test configuration for cross-platform path separator handling |
| testsuite/tests/misc/other-slash-in-path/test.py | Test script that creates directories with non-native separators and verifies proper handling |
| testsuite/drivers/asserts.py | Minor documentation improvement for assert_substring function |
| src/alire/alire-directories.adb | Core fix that scrubs paths before processing and improves error handling |
| deps/den | Updates den subproject commit to include path scrubbing functionality |
| alire.toml | Updates den dependency version and commit reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1984
PR creation checklist
doc/user-changes.mdhas been updated, if there are user-visible changes.doc/catalog-format-spec.mdhas been updated, if applicable.BREAKING.mdhas been updated for major changes inalr, minor/major in catalog format.